fix: Unpin SAML library. #32167
Merged
fix: Unpin SAML library. #32167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dianakhuang
force-pushed
the
diana/fix-saml-lib
branch
from
5713766 to
75b4429
Compare
johnnagro
approved these changes
May 2, 2023
adamstankiewicz
approved these changes
May 2, 2023
timmc-edx
reviewed
May 2, 2023
timmc-edx
approved these changes
May 2, 2023
We were using an old version of the python3-saml library, which was causing issues with newer versions of social-core. The reason it was pinned was because our etree implementation didn't support several fields that the saml library did, so we are now importing those entities as well.
dianakhuang
force-pushed
the
diana/fix-saml-lib
branch
from
9687eb2 to
8bef01c
Compare
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
timmc-edx
added a commit
that referenced
this pull request
May 30, 2023
We're seeing an issue with repeated attributes causing auth failure for some IdPs, and need to take some time to investigate. See unpinning issue #32327 for details. This is expected to reintroduce some bugs in testing SAML in devstack. This has the effect of reverting the following PRs: - Unpinned: #32167 (partial) - Upgraded: #32168 However, we're keeping the safe_lxml adjustments from the first PR, so it should be fine on that front to re-upgrade whenever we're ready.
This was referenced May 30, 2023
timmc-edx
added a commit
that referenced
this pull request
May 30, 2023
We're seeing an issue with repeated attributes causing auth failure for some IdPs, and need to take some time to investigate. See unpinning issue #32327 for details. This is expected to reintroduce some bugs in testing SAML in devstack. This has the effect of reverting the following PRs: - Unpinned: #32167 (partial) - Upgraded: #32168 However, we're keeping the safe_lxml adjustments from the first PR, so it should be fine on that front to re-upgrade whenever we're ready.
Yagnesh1998
pushed a commit
to ManpraXSoftware/edx-platform
that referenced
this pull request
Jun 8, 2023
…32328) We're seeing an issue with repeated attributes causing auth failure for some IdPs, and need to take some time to investigate. See unpinning issue openedx#32327 for details. This is expected to reintroduce some bugs in testing SAML in devstack. This has the effect of reverting the following PRs: - Unpinned: openedx#32167 (partial) - Upgraded: openedx#32168 However, we're keeping the safe_lxml adjustments from the first PR, so it should be fine on that front to re-upgrade whenever we're ready.
Yagnesh1998
pushed a commit
to ManpraXSoftware/edx-platform
that referenced
this pull request
Jun 8, 2023
…32328) We're seeing an issue with repeated attributes causing auth failure for some IdPs, and need to take some time to investigate. See unpinning issue openedx#32327 for details. This is expected to reintroduce some bugs in testing SAML in devstack. This has the effect of reverting the following PRs: - Unpinned: openedx#32167 (partial) - Upgraded: openedx#32168 However, we're keeping the safe_lxml adjustments from the first PR, so it should be fine on that front to re-upgrade whenever we're ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using an old version of the python3-saml library, which was causing issues with newer versions of social-core.
The reason it was pinned was because our etree implementation didn't support several fields that the saml library did, so we are now importing those entities as well.
This primarily affected devstack and any other version of Open edX that was running on a non-standard port.
edx/edx-arch-experiments#281