Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thirty-party auth for SAML is not testable in devstack #281

Closed
2 tasks
robrap opened this issue May 1, 2023 · 1 comment
Closed
2 tasks

Thirty-party auth for SAML is not testable in devstack #281

robrap opened this issue May 1, 2023 · 1 comment
Assignees

Comments

@robrap
Copy link
Contributor

robrap commented May 1, 2023

AC:

  • Make SAML work on devstack.
  • Ticket follow-up for Enterprise if needed.

Other notes:

The Enterprise is running into an issue and they aren't able to test SAML locally in devstack any more.

See https://twou.slack.com/archives/C04ACDVM6A1/p1682704109420539. (copy details here)

The issue is that we're seeing this error when trying to test in devstack:

Authentication failed: SAML login failed: ['invalid_response'] 
(the response was received at http://localhost/auth/complete/tpa-saml instead 
of http://localhost:18000/auth/complete/tpa-saml)

There is an existing workaround where we map lms to port 80 on the host machine, which does work, but we would not like to not have to deal with that.

This ticket is about making things testable in devstack. It may be that Enterprise also needs follow-up support on the actual bug they were trying to fix as well.

@robrap robrap added this to Arch-BOM May 1, 2023
@robrap robrap converted this from a draft issue May 1, 2023
@robrap robrap moved this to Prioritized in Arch-BOM May 1, 2023
@robrap robrap moved this from Prioritized to In Progress in Arch-BOM May 1, 2023
@dianakhuang
Copy link
Member

I believe this issue is caused by this constraint: https://github.com/openedx/edx-platform/blob/master/requirements/constraints.txt#L43-L44 which pins python3-saml to version 1.09

Version 1.12 deprecated the 'server_port' field: https://github.com/SAML-Toolkits/python3-saml/blob/master/changelog.md#1120-aug-13-2021

I believe that the upstream libraries like social-core also removed this field, but the old version of the code we're using still expects it.

A naive attempt at updating this library broke something in our implementation of lxml.

@dianakhuang dianakhuang moved this from In Progress to Done in Arch-BOM May 4, 2023
@jristau1984 jristau1984 moved this from Done to Done - Long Term Storage in Arch-BOM Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done - Long Term Storage
Development

No branches or pull requests

2 participants