Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Pin python3-saml again for duplicate attributes issue #32328

Merged
merged 1 commit into from
May 30, 2023
Merged

feat: Pin python3-saml again for duplicate attributes issue #32328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions requirements/constraints.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,3 +101,11 @@ urllib3<2.0.0
# Sphinx==5.3.0 requires docutils<0.20
# Issue to unpin Sphinx to resolve this constraint: https://github.com/openedx/edx-lint/issues/338
docutils<0.20

# When we unpinned python3-saml and allowed it to upgrade from 1.9.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great comment to leave here, thank you.

# to 1.15.0 it fixed a devstack issue around ports being dropped, but
# introduced an issue around duplicate attributes (for some
# IdPs). It's not clear which version introduces the second problem.
#
# Issue for unpinning: https://github.com/openedx/edx-platform/issues/32327
python3-saml<1.10.0
8 changes: 5 additions & 3 deletions requirements/edx/base.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@ defusedxml==0.7.1
# djangorestframework-xml
# ora2
# python3-openid
# python3-saml
# social-auth-core
deprecated==1.2.13
# via jwcrypto
Expand Down Expand Up @@ -689,7 +690,6 @@ lxml==4.9.2
# olxcleaner
# openedx-calc
# ora2
# python3-saml
# xblock
# xmlsec
mailsnake==1.6.4
Expand Down Expand Up @@ -932,8 +932,10 @@ python3-openid==3.2.0 ; python_version >= "3"
# via
# -r requirements/edx/base.in
# social-auth-core
python3-saml==1.15.0
# via -r requirements/edx/base.in
python3-saml==1.9.0
# via
# -c requirements/edx/../constraints.txt
# -r requirements/edx/base.in
pytz==2022.7.1
# via
# -c requirements/edx/../constraints.txt
Expand Down
8 changes: 5 additions & 3 deletions requirements/edx/development.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,7 @@ defusedxml==0.7.1
# djangorestframework-xml
# ora2
# python3-openid
# python3-saml
# social-auth-core
deprecated==1.2.13
# via
Expand Down Expand Up @@ -926,7 +927,6 @@ lxml==4.9.2
# openedx-calc
# ora2
# pyquery
# python3-saml
# xblock
# xmlsec
mailsnake==1.6.4
Expand Down Expand Up @@ -1315,8 +1315,10 @@ python3-openid==3.2.0 ; python_version >= "3"
# via
# -r requirements/edx/testing.txt
# social-auth-core
python3-saml==1.15.0
# via -r requirements/edx/testing.txt
python3-saml==1.9.0
# via
# -c requirements/edx/../constraints.txt
# -r requirements/edx/testing.txt
pytz==2022.7.1
# via
# -c requirements/edx/../constraints.txt
Expand Down
8 changes: 5 additions & 3 deletions requirements/edx/testing.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,7 @@ defusedxml==0.7.1
# djangorestframework-xml
# ora2
# python3-openid
# python3-saml
# social-auth-core
deprecated==1.2.13
# via
Expand Down Expand Up @@ -880,7 +881,6 @@ lxml==4.9.2
# openedx-calc
# ora2
# pyquery
# python3-saml
# xblock
# xmlsec
mailsnake==1.6.4
Expand Down Expand Up @@ -1240,8 +1240,10 @@ python3-openid==3.2.0 ; python_version >= "3"
# via
# -r requirements/edx/base.txt
# social-auth-core
python3-saml==1.15.0
# via -r requirements/edx/base.txt
python3-saml==1.9.0
# via
# -c requirements/edx/../constraints.txt
# -r requirements/edx/base.txt
pytz==2022.7.1
# via
# -c requirements/edx/../constraints.txt
Expand Down