This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Expose queue rejection time period setting in rca.conf #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khushbr
reviewed
Aug 7, 2020
khushbr
approved these changes
Aug 7, 2020
sruti1312
approved these changes
Aug 7, 2020
yojs
reviewed
Aug 7, 2020
pa_config/rca.conf
Outdated
| @@ -49,6 +49,10 @@ | |||
| "promotion-rate-mb-per-second" : 500, | |||
| "young-gen-gc-time-ms-per-second" : 400 | |||
| }, | |||
| //queue rejection rca | |||
There was a problem hiding this comment.
The comment is the key name itself. It may be removed.
| } | ||
|
|
||
| public static class RCA_CONF_KEY_CONSTANTS { | ||
| public static final String REJECTION_TIME_PERIOD_IN_SECONDS = "rejection-time-period-in-seconds"; |
There was a problem hiding this comment.
Is there a reason why it should be in a static inner class of its own ?
There was a problem hiding this comment.
the reason is because we might want to add more settings to this RCA in the future so it would be better to keep all consts under the same inner class.
Codecov Report
@@ Coverage Diff @@
## master #356 +/- ##
============================================
- Coverage 67.20% 67.17% -0.04%
- Complexity 2082 2087 +5
============================================
Files 300 301 +1
Lines 13311 13326 +15
Branches 1103 1104 +1
============================================
+ Hits 8946 8952 +6
- Misses 3959 3970 +11
+ Partials 406 404 -2
Continue to review full report at Codecov.
|
khushbr
pushed a commit
that referenced
this pull request
Sep 30, 2020
Changes for 1 package (OpenDistroPerformanceAnalyzerEngine), pushed in snapshot... https://code.amazon.com/snapshots/partsrut/2020-08-08T02-49-04 Changes for OpenDistroPerformanceAnalyzerEngine package: 0194f9f Fix failing reaction wheel tests bfdb93d Merge remote-tracking branch 'upstream/master' e03a120 Use StringUtils instead of NumberUtils to check timestamp string (#360) 79841f2 Expose queue rejection time period setting in rca.conf (#356) f9dfda5 Implement isMuted method in DummyAction (#355) 7ede0b9 Reader changes for dynamic enable/disable of RCA graph components (#325) ee58207 Fix bug in publisher to support cool off period on a per node basis (#351) cr https://code.amazon.com/reviews/CR-31344155
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
#357
Description of changes:
Expose queue rejection time period setting in rca.conf
Tests:
tested on docker
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.