This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Implement isMuted method in DummyAction #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rguo-aws
approved these changes
Aug 7, 2020
yojs
approved these changes
Aug 7, 2020
Codecov Report
@@ Coverage Diff @@
## master #355 +/- ##
============================================
- Coverage 67.28% 67.13% -0.16%
- Complexity 2051 2079 +28
============================================
Files 298 300 +2
Lines 13168 13311 +143
Branches 1087 1103 +16
============================================
+ Hits 8860 8936 +76
- Misses 3914 3969 +55
- Partials 394 406 +12
Continue to review full report at Codecov.
|
khushbr
pushed a commit
that referenced
this pull request
Sep 30, 2020
Changes for 1 package (OpenDistroPerformanceAnalyzerEngine), pushed in snapshot... https://code.amazon.com/snapshots/partsrut/2020-08-08T02-49-04 Changes for OpenDistroPerformanceAnalyzerEngine package: 0194f9f Fix failing reaction wheel tests bfdb93d Merge remote-tracking branch 'upstream/master' e03a120 Use StringUtils instead of NumberUtils to check timestamp string (#360) 79841f2 Expose queue rejection time period setting in rca.conf (#356) f9dfda5 Implement isMuted method in DummyAction (#355) 7ede0b9 Reader changes for dynamic enable/disable of RCA graph components (#325) ee58207 Fix bug in publisher to support cool off period on a per node basis (#351) cr https://code.amazon.com/reviews/CR-31344155
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
Fixes #354
Description of changes:
Fixes the build failure caused by DummyAction not implementing isMuted() now.
Tests:
Build is passing.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.