Use StringUtils instead of NumberUtils to check timestamp string (#360)

* Use StringUtils instead of NumberUtils to check timestamp string * Remove unused imports
opendistro-for-elasticsearch · Aug 8, 2020 · e03a120 · e03a120
1 parent 79841f2
commit e03a120
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/...opendistro/elasticsearch/performanceanalyzer/config/overrides/ConfigOverridesApplier.java b/...opendistro/elasticsearch/performanceanalyzer/config/overrides/ConfigOverridesApplier.java
@@ -22,7 +22,7 @@
 import java.io.IOException;
 import java.util.HashSet;
 import java.util.Set;
-import org.apache.commons.lang3.math.NumberUtils;
+import org.apache.commons.lang3.StringUtils;
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
 
@@ -115,7 +115,7 @@ private boolean valid(final String overridesJson, final String timestamp) {
       return false;
     }
 
-    return NumberUtils.isCreatable(timestamp);
+    return StringUtils.isNumeric(timestamp);
   }
 
   @VisibleForTesting

diff --git a/...elasticsearch/performanceanalyzer/decisionmaker/actions/ModifyCacheMaxSizeActionTest.java b/...elasticsearch/performanceanalyzer/decisionmaker/actions/ModifyCacheMaxSizeActionTest.java
@@ -31,12 +31,10 @@
 import com.amazon.opendistro.elasticsearch.performanceanalyzer.grpc.ResourceEnum;
 import com.amazon.opendistro.elasticsearch.performanceanalyzer.rca.configs.CacheDeciderConfig;
 import com.amazon.opendistro.elasticsearch.performanceanalyzer.rca.framework.api.summaries.ResourceUtil;
-import com.amazon.opendistro.elasticsearch.performanceanalyzer.rca.framework.core.Stats;
 import com.amazon.opendistro.elasticsearch.performanceanalyzer.rca.framework.util.InstanceDetails;
 import com.amazon.opendistro.elasticsearch.performanceanalyzer.rca.store.rca.cluster.NodeKey;
 import com.google.common.collect.ImmutableSet;
 import java.util.Map;
-import org.checkerframework.checker.units.qual.Temperature;
 import org.junit.Before;
 import org.junit.Test;