-
Notifications
You must be signed in to change notification settings - Fork 31
Backport from branch opendistro-1.12.0.0 to 7.9.1 #245
Backport from branch opendistro-1.12.0.0 to 7.9.1 #245
Conversation
When user=null or tenant=null, tenant is considered "" The APIs match for tenant info from user context
…tro-for-elasticsearch#222) * Use custom chrome binary * Update chromium path * Test workflow for al2 * Disable tests temporarily * Fix workflow Fix workflow * Rename opendistroKibanaReports to opendistroReportsKibana * Update workflows Fix workflow Update workflows Update workflows * Enable tests in workflows * Add windows chromium to workflows * Fix tests * Use path.posix.normalize to accomondate windows * Use @types/puppeteer-core
…arch#228) * Add arm chrome to workflows * Update release workflow * Fix workflow * Add puppeteer-core as it's not included in kibana-oss * Address comments
…csearch#231) * Fix report scheduler release workflow * Fix uploading artifacts
* Fix chromium path * Add more possible paths * Add error message * Use plugin id constant
…asticsearch#233) * Fix path * Fix path for kibana reports * Change s3 bucket paths and artifact name * Fix path * Use kibana-oss in release workflow
fix conflicts and use 9200 for AES
…icsearch#229) * Headless chrome creation script and readme file * Rename README_chrome_headless.md to README.md * Add README.md * add comments on how to run chrome to get pdf and png report * Change test web from google.com to https://opendistro.github.io/for-elasticsearch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@zhongnansu looks like basepath can be retrieved from and port is if they don't work maybe read from frontend url or ping a few possible |
Good point! I wasn't able to find how to access port before. Your solution sounds promising, the only thing left is to rebuild the input validation for the relative url. Do you know if there is a way to expose basePath to UI, or access basePath from UI code? Basically, we need to clean the url from UI before passing to server, so that the old input validation will work and robust with minor modification |
That will be part of the |
Hi @zhongnansu Only some parameters from Kibana.yml are exposed via CoreSetup
Theses parameters can be accessed as follow from any server method that has CoreSetup as a parameter
The CoreSetup can instance is the one used at the server level plugin initilization
|
Issue #, if available:
Description of changes:
LOCAL_HOST
from5601
to9200
for AESBASE_PATH = "/_plugin/kibana"
for AEScommon-utils:1.11.1.0
inbuild.gradle
TODO
port
andbasePath
. This will also remove the limitation of current reporting on OD, where reporting only works if user use defaultserver.basePath
andserver.port
in Kibana.yml. The code change should be pushed todev
branch and backport to7.9.1
branch if needed.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.