This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
Update workflow to build artifact for ARM64 #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongnansu
reviewed
Dec 1, 2020
| @@ -32,9 +32,9 @@ jobs: | |||
| run: | | |||
There was a problem hiding this comment.
This step is missing in the release flow
There was a problem hiding this comment.
Added, although I think we only need to test in CI, shouldn't need to test in CD?
There was a problem hiding this comment.
it may be a requirement from infra team, guess all the plugins are doing this way
|
Do we have plan to add chromium artifacts for macOS? |
zhongnansu
approved these changes
Dec 1, 2020
I don't think so, ODFE doesn't have a mac version |
developers may want it |
zhongnansu
pushed a commit
to zhongnansu/kibana-reports
that referenced
this pull request
Dec 4, 2020
…arch#228) * Add arm chrome to workflows * Update release workflow * Fix workflow * Add puppeteer-core as it's not included in kibana-oss * Address comments
zhongnansu
pushed a commit
to zhongnansu/kibana-reports
that referenced
this pull request
Dec 7, 2020
…arch#228) * Add arm chrome to workflows * Update release workflow * Fix workflow * Add puppeteer-core as it's not included in kibana-oss * Address comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
puppeteer-coreas it's not included in kibana-ossArtifact names:
opendistroReportsKibana-1.12.0.0-linux-x64.zipopendistroReportsKibana-1.12.0.0-linux-arm64.zipopendistroReportsKibana-1.12.0.0-windows-x64.zipBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.