This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
Use new API to Generate Reports from Existing Definitions #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akbhatta
approved these changes
Nov 24, 2020
zhongnansu
reviewed
Nov 24, 2020
Comment on lines
467
to
469
| reportDefinitionRawResponse.report_definition.report_params.core_params | ||
| .time_duration; | ||
| const fromDate = getRelativeStartDate(duration); |
There was a problem hiding this comment.
No, good catch. Will remove
There was a problem hiding this comment.
Can you verify if it's the same situation for logic in create_report_defintion.ts? I always have an impression that lots of code can be removed with this new API
There was a problem hiding this comment.
Do you mean create_report_definition.tsx? If so, yes. From the code change in the PR, the only parameter that is created is a reportDefinitionId constant based on the response from the Create API call
zhongnansu
approved these changes
Nov 24, 2020
zhongnansu
pushed a commit
to zhongnansu/kibana-reports
that referenced
this pull request
Dec 4, 2020
zhongnansu
pushed a commit
to zhongnansu/kibana-reports
that referenced
this pull request
Dec 7, 2020
zhongnansu
pushed a commit
to zhongnansu/kibana-reports
that referenced
this pull request
Dec 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Refactored to call new API for generating reports from existing definitions- instead of passing in the entire metadata of creating a report, we only have to pass in the
reportDefinitionIdnow.Usages:
Generate reportbutton on theReport definition detailspage for an on-demand definition.File formatwithinReport definition details.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.