Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize React Redux #213

Closed
Arnei opened this issue Oct 13, 2023 · 2 comments · Fixed by #214
Closed

Modernize React Redux #213

Arnei opened this issue Oct 13, 2023 · 2 comments · Fixed by #214
Labels
type:enhancement New feature or request

Comments

@Arnei
Copy link
Member

Arnei commented Oct 13, 2023

Our redux code is still "oldschool", meaning it's unwieldy, there's a hell of a lot of boilerplate and it's nearly impossible to type well. Therefore we should try to migrate to "modern" redux, using redux-toolkit.

Also recommended by the developers of React Redux: https://redux.js.org/usage/migrating-to-modern-redux
@Arnei Arnei added the type:enhancement New feature or request label Oct 13, 2023
@Arnei Arnei mentioned this issue Oct 16, 2023
Merged
@owi92 owi92 mentioned this issue Nov 21, 2023
Merged
@Arnei Arnei reopened this Dec 19, 2023
@Arnei
Copy link
Member Author

Arnei commented Dec 19, 2023

#214 did not fully resolve this issue, so reopening. This is one of those issues that gets resolved over multiple PRs anyway. #214 does however serve as a reference on how to further resolve this issue.

This was referenced Dec 19, 2023
Merged
Merged
Merged
This was referenced Jan 8, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Arnei added a commit to Arnei/opencast-admin-interface that referenced this issue Mar 6, 2024
@Arnei
Modernize redux: tableFilterProfilesSlice
6aa23b0 
Helps with opencast#213.

Switching to redux toolkit for handling table filter
profiles (you can save your table filters into
various profiles).
@Arnei Arnei mentioned this issue Mar 6, 2024
Merged
Arnei added a commit to Arnei/opencast-admin-interface that referenced this issue Mar 6, 2024
@Arnei
Modernize redux: tableFilterProfilesSlice
4826b35 
Helps with opencast#213.

Switching to redux toolkit for handling table filters.
@Arnei Arnei mentioned this issue Mar 6, 2024
Merged
Arnei added a commit to Arnei/opencast-admin-interface that referenced this issue Apr 5, 2024
@Arnei
Modernize Redux: AclThunks
5cca245 
Helps with opencast#213.

Forgot to look at the thunks when modernizing
 aclSlice.  This rectifies that.

 Arguably some of these could have been
 turned into `createAsyncThunk` and have
 their results stored in redux. However, this
 would not only require major rewrites for
 the components using those thunks, but
 also child components who all rely on the
 current code structure. This was deemed
 too much work for what this PR wanted to
 achieve.
@Arnei Arnei mentioned this issue Apr 5, 2024
Merged
Arnei added a commit to Arnei/opencast-admin-interface that referenced this issue May 13, 2024
@Arnei
Modernize redux: tableFilterProfilesSlice
768daec 
Helps with opencast#213.

Switching to redux toolkit for handling table filters.
@Arnei Arnei mentioned this issue Jun 13, 2024
Merged
@Arnei
Copy link
Member Author

Arnei commented Sep 11, 2024

I dare say this is solved by now. If anything else needs to be modernized, a new issue will probably be more useful.

@Arnei Arnei closed this as completed Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modernize redux Arnei/opencast-admin-interface
1 participant
@Arnei