Modernize redux: tableSlice #695
Conversation
Move table actions and reducers into tableSlice.
As expected, row is complicated in that some properties are only present for some types of tables.
Typing table thunks and removing the last uses of connect. Simplifies our code and provides us with some typechecking. There is still some serious typing left to do, especially the "Row" type in tableSlice.ts
I may struggle with writing a proper "Row" type for tableSlice.ts, but what types the individual table cell components are expecting seems pretty clear to me.
Adds typing based on the current state of our code. Arguably this could be handled better.
|
This pull request has conflicts ☹ |
|
This pull request is deployed at test.admin-interface.opencast.org/695/2024-07-05_11-29-54/ . |
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
|
This pull request has conflicts ☹ |
|
This pull request has conflicts ☹ |
Arnei
force-pushed
the
to-redux-toolkit-table
branch
from
bd2e030 to
8d6cfc8
Compare
|
This pull request has conflicts ☹ |
|
This pull request has conflicts ☹ |
|
LGTM |
Hello potential reviewer! Even if the number of code changes seems daunting to you and you don't know what this is about, please consider testing this anyway. This patch should not change any behaviour in the UI, so testing if everything still works as expected would be greatly appreciated!
Helps with #213.
Switching to redux toolkit for our central table reducers.
This is the last big PR on this topic. After this, I would consider our migration to redux toolkit complete (finally), although there certainly is still room for improvement.