Modernize redux: eventDetailsSlice #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While storing dates as date objects in redux does not necessarily break anything, it can interfere with some features (persisting, debugging) and lead to bad practices (for an encompassing discussion see reduxjs/redux-toolkit#456). This changes the scheduling info fetching method to store dates as strings
Turns out even more of the parameters for the addNotification function in the notificationThunks are perfectly optional.
Fixes a "can't access lexical declaration 'X' before initialization" error, by resolving a kind of circular dependency.
Switching to redux toolkit for getting event details for the event details modal.
Adds types to the redux state for event details. Also fixes small errors regarding fetching workflow details introduced in the previous commit.
|
This pull request has conflicts ☹ |
owi92
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Event details modal is working. (See #242 (review) for more info on these approvals)
|
This pull request has conflicts ☹ |
|
This pull request has conflicts ☹ |
|
This pull request has conflicts ☹ |
…oolkit-eventDetails
…oolkit-eventDetails
Statistics were commented out for statistics in the events details tab. This comments the functionality back in and fixes it by making use of the new functionality offeered by statisticsSlice.ts. Same as for the "Modernize Statistics" PR, I have not tested this with actual statistics, because setting that up is very hard for some reason.
|
This pull request has conflicts ☹ |
…oolkit-eventDetails
…oolkit-eventDetails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with #213.
Switching to redux toolkit for getting event details for the event details modal.
This breaks statistics for the event details! To be fixed after #264 is merged.
(Feels like the event details alone send more different web requests then the rest of the ui combined, sheesh)