Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(messaging): add gcp async batch publish example #545

Merged
merged 18 commits into from
Jan 10, 2024

Conversation

alevenberg
Copy link
Contributor

@alevenberg alevenberg commented Nov 20, 2023

Part of #527

Changes

Add an example for gcp_pubsub asynchronous batch publish.

Merge requirement checklist

@alevenberg
Copy link
Contributor Author

I'm not sure if you can preview the figures, so here's what I get from my IDE:

mermaid diagram preview
table preview

@alevenberg alevenberg marked this pull request as ready for review November 20, 2023 20:44
@alevenberg alevenberg requested review from a team November 20, 2023 20:44
docs/messaging/gcp-pubsub.md Outdated Show resolved Hide resolved
docs/messaging/gcp-pubsub.md Outdated Show resolved Hide resolved
docs/messaging/gcp-pubsub.md Outdated Show resolved Hide resolved
@alevenberg alevenberg marked this pull request as draft November 21, 2023 18:54
@alevenberg
Copy link
Contributor Author

I'm going to be OOO for the next few days. I plan on taking a look at the comments next tuesday.

@alevenberg alevenberg marked this pull request as ready for review November 29, 2023 16:14
@alevenberg
Copy link
Contributor Author

Updated screenshots of the figure and chart
Screenshot 2023-11-29 at 11 15 28 AM
Screenshot 2023-11-29 at 11 15 22 AM

docs/messaging/gcp-pubsub.md Outdated Show resolved Hide resolved
docs/messaging/gcp-pubsub.md Outdated Show resolved Hide resolved
docs/messaging/gcp-pubsub.md Outdated Show resolved Hide resolved
@pyohannes
Copy link
Contributor

CHANGELOG.md Outdated Show resolved Hide resolved
docs/messaging/gcp-pubsub.md Outdated Show resolved Hide resolved
docs/messaging/gcp-pubsub.md Outdated Show resolved Hide resolved
alevenberg and others added 2 commits December 4, 2023 14:29
docs/messaging/gcp-pubsub.md Outdated Show resolved Hide resolved
docs/messaging/gcp-pubsub.md Outdated Show resolved Hide resolved
@alevenberg alevenberg changed the title docs(messaging): add message link attribute and example docs(messaging): add gcp async batch publish example Dec 13, 2023
@joaopgrassi joaopgrassi merged commit de9ef07 into open-telemetry:main Jan 10, 2024
9 checks passed
pyohannes added a commit to pyohannes/semantic-conventions that referenced this pull request Jan 17, 2024
)

Co-authored-by: Liudmila Molkova <[email protected]>
Co-authored-by: Alex Hong <[email protected]>
Co-authored-by: Johannes Tax <[email protected]>
Co-authored-by: Josh Suereth <[email protected]>
Co-authored-by: Joao Grassi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Trace Messaging semantics to add example on Batch Send scenario
7 participants