-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trace Messaging semantics to add example on Batch Send scenario #1466
Trace Messaging semantics to add example on Batch Send scenario #1466
Comments
Actually in Batch Processing section, the references to C1, C2 and C3 seem to appear in the explanation out of the blue causing confusion! Perhaps we can refer to them as Recv1, Recv2, Proc1 instead of C1, C2 and C3? |
@ramthi What do you mean by "out of the blue"? They are in the diagram and in the table, and are named after the processes and I guess the C is for Consume. "Recv" would be a wrong name, as they are "process" not "receive" spans (see messaging.operation). |
In a send scenario, isn't usually the current span the correct parent for the send span? I.e. I think all the messages in an outgoing batch would usually not only have the same trace but even the same parent span. Or are you thinking of a more complex scenario? |
To make sure I understand you are saying the messages in the batch might have different trace or if within the same trace could have different parent span. That's the scenario I'm referring as well. So in this case when the Batch send operation happens should the Span generated have links to individual messages being sent as part of the batch. |
This is an issue only for the Batch Processing example. Other examples are labelled correctly. |
@Kanwaldeep Thanks for clarifying. Apologies for not keeping an eye on this PR. It got buried in all my github notifications |
The current specification has details on Batch Processing and Batch Receiving which is very helpful. Can we add example for Batch send scenario when multiple messages are added to the queue as part of Batch operation? In this case each message could be part of different traces but being added as a batch to the queue.
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/messaging.md#examples
The text was updated successfully, but these errors were encountered: