Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pubsub): modify attributes according to otel spec #13263

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

alevenberg
Copy link
Member

@alevenberg alevenberg commented Dec 11, 2023

Changes in open-telemetry/semantic-conventions#545

  • Fixes for the publisher
    Publish span
  • Remove the link # attribute
  • Add a full name topic attribute
  • Add a gcp_pubsub attribute
  • Change publish to client not producer
    Create span
  • Remove topic attribute

This change is Reviewable

@alevenberg alevenberg requested a review from a team as a code owner December 11, 2023 17:25
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c5393be) 93.05% compared to head (7768597) 93.05%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13263   +/-   ##
=======================================
  Coverage   93.05%   93.05%           
=======================================
  Files        2137     2137           
  Lines      186562   186565    +3     
=======================================
+ Hits       173610   173614    +4     
+ Misses      12952    12951    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alevenberg alevenberg enabled auto-merge (squash) December 11, 2023 18:09
@alevenberg alevenberg merged commit feade4e into googleapis:main Dec 11, 2023
59 checks passed
@alevenberg alevenberg deleted the refactor-10 branch December 11, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants