-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
container: add CSI attributes #1337
Conversation
Co-authored-by: Joshua MacDonald <[email protected]>
Co-authored-by: Joshua MacDonald <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to update things via the make targets:
make fix
make generate-gh-issue-templates
I ran into a couple little snags:
|
/cc @open-telemetry/semconv-container-approvers @open-telemetry/semconv-k8s-approvers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@jmacd could you please take another look? I believe your feedback is addressed. |
Co-authored-by: Joshua MacDonald <[email protected]> Co-authored-by: Joao Grassi <[email protected]> Co-authored-by: Christos Markou <[email protected]>
Hey @gdvalle, is there a reason why those were only added in the registry and not as Resource Attributes as well? |
No, just my oversight. See #1499 for adding to resource attributes. |
Fixes #1119
Changes
Add CSI (Container Storage Interface) attributes:
container.csi.plugin.name
andcontainer.csi.volume.id
.Merge requirement checklist
[chore]
xref open-telemetry/opentelemetry-collector-contrib#32055 (comment)