Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s: new attributes: CSI driver and volume handle #1119

Closed
gdvalle opened this issue Jun 3, 2024 · 3 comments · Fixed by #1337
Closed

k8s: new attributes: CSI driver and volume handle #1119

gdvalle opened this issue Jun 3, 2024 · 3 comments · Fixed by #1337
Assignees
Labels
area:k8s enhancement New feature or request experts needed This issue or pull request is outside an area where general approvers feel they can approve

Comments

@gdvalle
Copy link
Contributor

gdvalle commented Jun 3, 2024

Area(s)

Semantic convention for otelcol's kubeletstatsreceiver, area:k8s.

Is your change request related to a problem? Please describe.

In k8s, I would like to record CSI driver and volume handle information for relevant Persistent Volume Claims (PVCs) to be able to associate metrics to underlying disks.

Describe the solution you'd like

Two new attributes, with each mapping 1:1 to the respective driver/volumeHandle fields in CSIPersistentVolumeSource:

  • csi.driver
  • csi.volume.handle

And a new value for the k8s.volume.type attribute, csiPersistentVolume.

Describe alternatives you've considered

None

Additional context

This grew from open-telemetry/opentelemetry-collector-contrib#32055

@gdvalle gdvalle added enhancement New feature or request experts needed This issue or pull request is outside an area where general approvers feel they can approve triage:needs-triage labels Jun 3, 2024
@ChrsMark
Copy link
Member

ChrsMark commented Jun 12, 2024

/cc @open-telemetry/semconv-k8s-approvers

Also related to #1032

@ChrsMark
Copy link
Member

There is no semantic convention for the k8s.volume.type. #1164 will add this.

@mx-psi
Copy link
Member

mx-psi commented Jul 25, 2024

I removed this from the system semantic conventions WG since this WG does not handle Kubernetes-related semantic conventions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:k8s enhancement New feature or request experts needed This issue or pull request is outside an area where general approvers feel they can approve
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants