-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix makefile docker ownership #1386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems to break policy check :(
docker run --rm \
-u 1001:127 \
--mount 'type=bind,source=/home/runner/work/semantic-conventions/semantic-conventions/policies,target=/home/weaver/policies,readonly' \
--mount 'type=bind,source=/home/runner/work/semantic-conventions/semantic-conventions/model,target=/home/weaver/source,readonly' \
otel/weaver:v0.9.1 registry check \
--registry=/home/weaver/source \
--baseline-registry=https://github.com/open-telemetry/semantic-conventions/archive/refs/tags/v1.27.0.zip[model] \
--policy=/home/weaver/policies
....
× Cache directory not created: Permission denied (os error [13](https://github.com/open-telemetry/semantic-conventions/actions/runs/10708326730/job/29690368799?pr=1386#step:3:14))
…-conventions into gtd.fix-makefile-docker
Doh. I don't think we need it here anyway, it's just a read-only mount, and unless we have world read off (not so common) this should work fine. Seems the weaver container is running under its own UID/GID. Removed in 33d0431 |
Co-authored-by: Liudmila Molkova <[email protected]>
Fix the docker user flag to properly fetch group and user IDs.
Without this, on linux with GNU Make 4, a new registry component will end up throwing an error:
because it writes out as root rather than the current user.