-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove dependency of urlencoding crate #1615
remove dependency of urlencoding crate #1615
Conversation
implement the url encode fn
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1615 +/- ##
=====================================
Coverage 67.8% 67.9%
=====================================
Files 139 139
Lines 19687 19726 +39
=====================================
+ Hits 13363 13398 +35
- Misses 6324 6328 +4 ☔ View full report in Codecov by Sentry. |
Fixes #1590 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix.
Fixes #
#1590
Design discussion issue (if applicable) #
Changes
Remove urlencoding dependency.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes