Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependency of urlencoding crate #1615

Merged
merged 17 commits into from
Mar 14, 2024

Conversation

sreeo
Copy link
Contributor

@sreeo sreeo commented Mar 12, 2024

Fixes #
#1590
Design discussion issue (if applicable) #

Changes

Remove urlencoding dependency.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@sreeo sreeo marked this pull request as ready for review March 12, 2024 04:09
@sreeo sreeo requested a review from a team March 12, 2024 04:09
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.9%. Comparing base (a8b308a) to head (a75940b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1615   +/-   ##
=====================================
  Coverage   67.8%   67.9%           
=====================================
  Files        139     139           
  Lines      19687   19726   +39     
=====================================
+ Hits       13363   13398   +35     
- Misses      6324    6328    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas
Copy link
Member

Fixes #1590

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@cijothomas cijothomas merged commit b7b7d7e into open-telemetry:main Mar 14, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants