Add more tests to Metric SDK aggregation #1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1600 +/- ##
=======================================
+ Coverage 67.0% 67.3% +0.3%
=======================================
Files 138 138
Lines 19479 19654 +175
=======================================
+ Hits 13058 13243 +185
+ Misses 6421 6411 -10 ☔ View full report in Codecov by Sentry. |
TommyCpp
reviewed
Mar 8, 2024
Comment on lines
+219
to
+220
| // "multi_thread" tokio flavor must be used else flush won't | ||
| // be able to make progress! |
There was a problem hiding this comment.
nit: don't think we need this for every test but not a strong opinion
Comment on lines
+229
to
+245
| let meter1 = meter_provider.meter("test.meter1"); | ||
| let meter2 = meter_provider.meter("test.meter2"); | ||
| let counter1 = meter1 | ||
| .u64_counter("my_counter") | ||
| .with_unit(Unit::new("my_unit")) | ||
| .with_description("my_description") | ||
| .init(); | ||
|
|
||
| let counter2 = meter2 | ||
| .u64_counter("my_counter") | ||
| .with_unit(Unit::new("my_unit")) | ||
| .with_description("my_description") | ||
| .init(); | ||
|
|
||
| let attribute = vec![KeyValue::new("key1", "value1")]; | ||
| counter1.add(10, &attribute); | ||
| counter2.add(5, &attribute); |
There was a problem hiding this comment.
We can just loop over test.meter1 and test.meter2 here?
sreeo
pushed a commit
to sreeo/opentelemetry-rust
that referenced
this pull request
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding more tests to test meter and instrument identify part, and whether they get merged or not.