Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urlencoding dependency removal #1590

Closed
cijothomas opened this issue Feb 29, 2024 · 2 comments
Closed

urlencoding dependency removal #1590

cijothomas opened this issue Feb 29, 2024 · 2 comments
Labels
A-common Area:common issues that not related to specific pillar good first issue Good for newcomers

Comments

@cijothomas
Copy link
Member

See #1578 (comment)

@cijothomas cijothomas added good first issue Good for newcomers A-common Area:common issues that not related to specific pillar labels Mar 1, 2024
@stormshield-fabs
Copy link
Contributor

For context, #1578 added support for percent-encoded OTEL_EXPORTER* environment variables. It was proposed to remove the urlencoding crate that indicated it's looking for a maintainer.

The specification states that "these are expected to be represented in a format matching to the W3C Baggage" (link to the exporter specification). The Baggage specification indicates that

Percent-encoding is defined in [RFC3986], Section 2.1: https://datatracker.ietf.org/doc/html/rfc3986#section-2.1

I was about to propose Servo's percent_encoding but it turns out it does not implement RFC3986.

@TommyCpp
Copy link
Contributor

close via #1615

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-common Area:common issues that not related to specific pillar good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants