-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(scope-manager): implements AsyncHooks Scope Manager #103
feat(scope-manager): implements AsyncHooks Scope Manager #103
Conversation
7bcccbd
to
22b2f20
Compare
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
==========================================
- Coverage 98.87% 98.74% -0.14%
==========================================
Files 27 29 +2
Lines 1784 1915 +131
Branches 201 221 +20
==========================================
+ Hits 1764 1891 +127
- Misses 20 24 +4
|
@vmarchaud something like this might work |
packages/opentelemetry-scope-async-hooks/src/AsyncHooksScopeManager.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-scope-async-hooks/src/AsyncHooksScopeManager.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-scope-async-hooks/src/AsyncHooksScopeManager.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-scope-async-hooks/src/AsyncHooksScopeManager.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-scope-async-hooks/src/AsyncHooksScopeManager.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-scope-async-hooks/src/AsyncHooksScopeManager.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-scope-async-hooks/src/AsyncHooksScopeManager.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-scope-async-hooks/src/AsyncHooksScopeManager.ts
Outdated
Show resolved
Hide resolved
cc92e16
to
57e5b32
Compare
packages/opentelemetry-scope-async-hooks/src/AsyncHooksScopeManager.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-scope-async-hooks/src/AsyncHooksScopeManager.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-scope-async-hooks/src/AsyncHooksScopeManager.ts
Outdated
Show resolved
Hide resolved
83ad44f
to
12f232b
Compare
5245950
to
c170f89
Compare
Ready to be merged following discussion from SIG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small nits, but then should be good to go 👍
packages/opentelemetry-scope-async-hooks/src/AsyncHooksScopeManager.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-scope-async-hooks/src/AsyncHooksScopeManager.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-scope-async-hooks/src/AsyncHooksScopeManager.ts
Outdated
Show resolved
Hide resolved
9deb359
to
c72a91b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Could use more tests that the scope is actually propagated properly with all the different asynchronous constructs, but these can be added later.
…ry-3.x Update dependency @types/jquery to v3.5.0
I'm waiting on #100 to be merged so i can add more tests (and coverage) and itirate on this PR.Specific mention: i believe we are forced to cast to any in the
bindFunction
, if someone have an idea feel free to tell !