feat(scope-manager): Add no-op implementations of ScopeManager #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmarchaud
requested review from
danielkhan,
iredelmeier,
justindsmith,
mayurkale22 and
rochdev
as code owners
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
======================================
Coverage 100% 100%
======================================
Files 16 19 +3
Lines 1054 1163 +109
Branches 119 129 +10
======================================
+ Hits 1054 1163 +109
|
rochdev
suggested changes
Jul 12, 2019
packages/opentelemetry-scope-base/test/noop/scopemanager.test.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-scope-base/test/noop/scopemanager.test.ts
Outdated
Show resolved
Hide resolved
mayurkale22
reviewed
Jul 12, 2019
packages/opentelemetry-scope-base/test/noop/scopemanager.test.ts
Outdated
Show resolved
Hide resolved
vmarchaud
force-pushed
the
noop-scope-manager
branch
2 times, most recently
from
50d9bab to
0f3c83d
Compare
|
@rochdev @mayurkale22 I addressed the reviews |
draffensperger
approved these changes
Jul 12, 2019
mayurkale22
approved these changes
Jul 12, 2019
mayurkale22
approved these changes
Jul 12, 2019
vmarchaud
force-pushed
the
noop-scope-manager
branch
from
0f3c83d to
bd6c156
Compare
|
@vmarchaud Could you please rebase master and add back |
vmarchaud
force-pushed
the
noop-scope-manager
branch
from
bd6c156 to
a8dc9da
Compare
|
@mayurkale22 done |
rochdev
approved these changes
Jul 16, 2019
vmarchaud
force-pushed
the
noop-scope-manager
branch
from
a8dc9da to
18587e9
Compare
dyladan
pushed a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
dyladan
pushed a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.