-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ah-scope): add scope propagation for event emitters #146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice use of strong typing here 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments, but otherwise looks good 👍
packages/opentelemetry-scope-async-hooks/src/AsyncHooksScopeManager.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-scope-async-hooks/src/AsyncHooksScopeManager.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-scope-async-hooks/src/AsyncHooksScopeManager.ts
Outdated
Show resolved
Hide resolved
@rochdev I addressed your comments ! |
Codecov Report
@@ Coverage Diff @@
## master #146 +/- ##
=========================================
+ Coverage 93.32% 94.22% +0.9%
=========================================
Files 47 47
Lines 1587 1732 +145
Branches 94 114 +20
=========================================
+ Hits 1481 1632 +151
+ Misses 106 100 -6
|
Interesting. Do you get a different behavior by environment or even on your laptop it's sometimes different? |
@rochdev Its varying even on my laptop. I didn't get that problem with the old PR thought (with the event emitters and promises directly inside). |
cedad8b
to
565230b
Compare
@rochdev if you could re-review please |
c369818
to
598a1e3
Compare
Making a new PR for event emitters support with async hooks.
Link to initial PR issue with the current implementation: #103 (comment)
I was saying that i would expect this behavior:
@rochdev is the implementation using the scope at the
.on
moment would have the same behavior ? I'm not sure.