Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MESSAGING_OPERATION constant from SDK #1375

Closed
iNikem opened this issue Oct 12, 2020 · 1 comment · Fixed by #1457
Closed

Use MESSAGING_OPERATION constant from SDK #1375

iNikem opened this issue Oct 12, 2020 · 1 comment · Fixed by #1457
Assignees
@iNikem
Labels
enhancement New feature or request

Comments

@iNikem
Copy link
Contributor

iNikem commented Oct 12, 2020

instead of hard-coded strings. See open-telemetry/opentelemetry-java#1783
@iNikem iNikem self-assigned this Oct 12, 2020
@iNikem iNikem added the enhancement New feature or request label Oct 12, 2020
vadeg added a commit to vadeg/opentelemetry-java-instrumentation that referenced this issue Oct 22, 2020
@vadeg
Replace "messaging.operation" with the constant from Instrumentatio…
ad80a4c 
…n API

Fixes: open-telemetry#1375
This was referenced Oct 22, 2020
Merged
Closed
@vadeg
Copy link
Contributor

vadeg commented Oct 22, 2020

I think other constant can be also replaced. I created a follow up ticket for this #1458

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iNikem iNikem

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace "messaging.operation" with the constant vadeg/opentelemetry-java-instrumentation
2 participants
@iNikem @vadeg