Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace "messaging.operation" with the constant #1457

Merged
merged 2 commits into from
Oct 23, 2020
Merged

Replace "messaging.operation" with the constant #1457

merged 2 commits into from
Oct 23, 2020

Conversation

vadeg
Copy link
Contributor

@vadeg vadeg commented Oct 22, 2020

Replace "messaging.operation" with the constant from Instrumentation API

Fixes: #1375

trask
trask approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

anuraaga
anuraaga approved these changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@trask trask merged commit 96eb67d into open-telemetry:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

@iNikem iNikem iNikem approved these changes

@trask trask trask approved these changes

@anuraaga anuraaga anuraaga approved these changes

@jkwatson jkwatson Awaiting requested review from jkwatson

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use MESSAGING_OPERATION constant from SDK
5 participants
@vadeg @anuraaga @trask @iNikem @mateuszrzeszutek