Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constants for message operations which are defined by spec. #1783

Merged

Conversation

anuraaga
Copy link
Contributor

No description provided.

@anuraaga
Copy link
Contributor Author

I think this PR demonstrates that we need to split SemanticAttributes into multiple classes? Reasons

  • attributes.setAttribute(MESSAGING_OPERATION, MESSAGING_OPERATION_SEND) is stuttery
  • I don't see any way to automatically generate the current class based on the yaml files in a nice way

@thisthat
Copy link
Member

  • I don't see any way to automatically generate the current class based on the yaml files in a nice way

I'll open a draft PR to show how I would address the code generation. My idea is to provide an overload that accepts also enumerations as attribute values.

@jkwatson
Copy link
Contributor

@anuraaga Yes, I'd like to have the values moved into their own class. Maybe SemanticConventionValues or some such.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants