-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new values to allow custom ports #218
Added new values to allow custom ports #218
Conversation
@abelperezok can you change this to a draft PR until all other blocker PRs are merged? |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
@TylerHelmuth I've resolved the conflicts with the tag version, I kept the higher number. |
@abelperezok please bump the chart's patch version by 1. |
@TylerHelmuth chart version is now 0.8.2 |
@abelperezok chart testing failed twice in a row. Can you to |
For comparison, here is a passing build of essentially main (I bumped the version so I could make a PR): TylerHelmuth#12 |
@abelperezok thanks! |
This PR is related to the following issues:
It includes updates to the
opentelemetry-operator
chart to allow custom values to be used for ports:The default values for all these ports are the same as before and it's reflected in
values.yaml
https://github.com/abelperezok/opentelemetry-helm-charts/blob/new-values-custom-ports/charts/opentelemetry-operator/templates/deployment.yaml#L28-L29
Also, make sure you keep using the default values for both health check and webhook until the new version of the operator is published.