Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new values to allow custom ports #218

Merged
merged 5 commits into from
Jun 20, 2022

Conversation

abelperezok
Copy link
Contributor

This PR is related to the following issues:

It includes updates to the opentelemetry-operator chart to allow custom values to be used for ports:

--set manager.ports.metricsPort=8085
--set kubeRBACProxy.ports.proxyPort=8445
--set manager.ports.webhookPort=9445
--set manager.ports.healthzPort=8005

The default values for all these ports are the same as before and it's reflected in values.yaml

manager:
# other values ...
  ports:
    metricsPort: 8080
    webhookPort: 9443
    healthzPort: 8081

kubeRBACProxy:
# other values ....
  ports:
    proxyPort: 8443

⚠️ At this point, it's not going to work until PR open-telemetry/opentelemetry-operator#899 is completed. If you want to test it meanwhile, please comment out or remove the lines:

            - --health-probe-addr=:{{ .Values.manager.ports.healthzPort }}
            - --webhook-port={{ .Values.manager.ports.webhookPort }}

https://github.com/abelperezok/opentelemetry-helm-charts/blob/new-values-custom-ports/charts/opentelemetry-operator/templates/deployment.yaml#L28-L29

Also, make sure you keep using the default values for both health check and webhook until the new version of the operator is published.

@abelperezok abelperezok requested review from a team May 29, 2022 16:45
@TylerHelmuth
Copy link
Member

@abelperezok can you change this to a draft PR until all other blocker PRs are merged?

@abelperezok abelperezok marked this pull request as draft May 31, 2022 14:56
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@abelperezok abelperezok marked this pull request as ready for review June 15, 2022 16:04
@abelperezok
Copy link
Contributor Author

@TylerHelmuth I've resolved the conflicts with the tag version, I kept the higher number.

@TylerHelmuth
Copy link
Member

@abelperezok please bump the chart's patch version by 1.

@abelperezok
Copy link
Contributor Author

@TylerHelmuth chart version is now 0.8.2

@TylerHelmuth
Copy link
Member

@abelperezok chart testing failed twice in a row. Can you to
take a look?

@TylerHelmuth
Copy link
Member

For comparison, here is a passing build of essentially main (I bumped the version so I could make a PR): TylerHelmuth#12

@TylerHelmuth TylerHelmuth merged commit b75a0e6 into open-telemetry:main Jun 20, 2022
@TylerHelmuth
Copy link
Member

@abelperezok thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants