Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using custom port for webhook #896

Closed
abelperezok opened this issue May 27, 2022 · 2 comments
Closed

Allow using custom port for webhook #896

abelperezok opened this issue May 27, 2022 · 2 comments

Comments

@abelperezok
Copy link
Contributor

Related to open-telemetry/opentelemetry-helm-charts#214

Currently there are command line flags for metrics and health checks but not for the webhook itself

	pflag.StringVar(&metricsAddr, "metrics-addr", ":8080", "The address the metric endpoint binds to.")
	flag.StringVar(&probeAddr, "health-probe-addr", ":8081", "The address the probe endpoint binds to.")

It'd be good to add another flag something like:

--webhook-port=9444

Which then would be passed to

mgrOptions := ctrl.Options{ 
    Port: //   .....  value from the flag 
}

In this line https://github.com/open-telemetry/opentelemetry-operator/blob/main/main.go#L151

@yuriolisa
Copy link
Contributor

@abelperezok, does #899 close this issue?

@abelperezok
Copy link
Contributor Author

@yuriolisa Yes, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants