Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore Update OTEL Operator to v0.53.0 release #231

Merged
merged 5 commits into from
Jun 17, 2022
Merged

chore Update OTEL Operator to v0.53.0 release #231

merged 5 commits into from
Jun 17, 2022

Conversation

jaronoff97
Copy link
Contributor

@jaronoff97 jaronoff97 commented Jun 15, 2022 •
edited
Loading

This PR updates the OTEL operator the latest v0.53.0 release

closes #227

@jaronoff97 jaronoff97 requested review from a team June 15, 2022 14:20
@jaronoff97 jaronoff97 mentioned this pull request Jun 15, 2022
Closed
TylerHelmuth
TylerHelmuth reviewed Jun 15, 2022
View reviewed changes
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a huge change in the CRD from 0.51.0 to 0.53.0? Seems like a ton of changes. Also looks like there were some build failures.

charts/opentelemetry-operator/Chart.yaml Outdated Show resolved Hide resolved
@TylerHelmuth
Copy link
Member

@abelperezok please review to ensure this will allow #218

@abelperezok
Copy link
Contributor

@TylerHelmuth I don't see any conflicting change with #218
Not sure about the details in CRDs changes, maybe @jaronoff97 can provide some ideas.

@jaronoff97
Copy link
Contributor Author

jaronoff97 commented Jun 15, 2022 •
edited
Loading

The CRD changes can be seen below:
Screen Shot 2022-06-15 at 8 12 41 PM

Should be no conflicts with #218

@TylerHelmuth
Copy link
Member

TylerHelmuth commented Jun 16, 2022 •
edited
Loading

@jaronoff97 it looks to me like the CRDs were regenerated by something, which reordered content. Is that true? Are you able to manually update the CRDs so only the new changes are applied and the existing order is preserved?

TylerHelmuth
TylerHelmuth approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaronoff97 thanks for taking care of this. @dmitryax and I don't do much with the operator or the operator's chart so help is always appreciated.

@TylerHelmuth
Copy link
Member

@dmitryax please review

@dmitryax dmitryax merged commit fbaff9d into open-telemetry:main Jun 17, 2022
@jaronoff97 jaronoff97 deleted the 227-new-release branch June 17, 2022 17:52
@jaronoff97 jaronoff97 mentioned this pull request Jul 26, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@dmitryax dmitryax dmitryax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updated opentelemetry-operator chart default version to 0.52.0
4 participants
@jaronoff97 @TylerHelmuth @abelperezok @dmitryax