Exponential Histogram mapping functions for public use #2502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
requested review from
Aneurysm9,
dashpole,
evantorrie,
MadVikingGod,
MrAlias,
paivagustavo,
pellared and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2502 +/- ##
=======================================
+ Coverage 76.5% 76.7% +0.1%
=======================================
Files 178 181 +3
Lines 12072 12175 +103
=======================================
+ Hits 9242 9345 +103
Misses 2605 2605
Partials 225 225
|
Aneurysm9
approved these changes
Jan 11, 2022
👍 Co-authored-by: Anthony Mirabella <[email protected]>
MadVikingGod
approved these changes
Jan 20, 2022
MrAlias
approved these changes
Mar 22, 2022
Merged
This was referenced Jul 15, 2022
jmacd
added a commit
to lightstep/go-expohisto
that referenced
this pull request
Oct 5, 2022
contained in these OpenTelemetry-Go PRs: open-telemetry/opentelemetry-go#2982 open-telemetry/opentelemetry-go#2502 The data structure was reviewed by Lightstep engineers for inclusion in otel-launcher-go: lightstep/otel-launcher-go#174 lightstep/otel-launcher-go#215 lightstep/otel-launcher-go#222
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in #2501 when closing #2393 (for later), this introduces public packages in
sdk/metric/aggregator/exponential/mapping. This is a first step for adding exponential histogram support in OTel-Go as well as the OTel-Collector. (See for example open-telemetry/opentelemetry-collector#4642 and open-telemetry/opentelemetry-collector-contrib#6666).Follows the specification in open-telemetry/opentelemetry-specification#2252
Fixes #2501
Factored apart from #2393