Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore the exponential mapping functions #3243

Closed
wants to merge 1 commit into from

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Sep 29, 2022

The exponential mapping functions that had been originally reviewed in #2502 (matching specification v1.8) and modified in #2982 (matching specification v1.13). This code is unmodified from its previous state, only the package names change.

The proposed new path for this code is sdk/metric/metricdata/exponential/mapping.

Fixes #3169

The corresponding structure would be its sibling in sdk/metric/metricdata/exponential/structure (part of #3170).

Part of #2966.

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #3243 (ad89d96) into main (aca054b) will increase coverage by 0.2%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3243     +/-   ##
=======================================
+ Coverage   77.3%   77.6%   +0.2%     
=======================================
  Files        159     162      +3     
  Lines      11184   11295    +111     
=======================================
+ Hits        8651    8766    +115     
+ Misses      2335    2331      -4     
  Partials     198     198             
Impacted Files Coverage Δ
...etricdata/exponential/mapping/exponent/exponent.go 100.0% <100.0%> (ø)
...metricdata/exponential/mapping/internal/float64.go 100.0% <100.0%> (ø)
...ricdata/exponential/mapping/logarithm/logarithm.go 100.0% <100.0%> (ø)
sdk/trace/batch_span_processor.go 81.9% <0.0%> (+1.7%) ⬆️

@jmacd
Copy link
Contributor Author

jmacd commented Oct 13, 2022

There are now slight upstream changes (e.g., an improved comment). https://github.com/lightstep/go-expohisto

@jmacd jmacd closed this Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore stand-alone exponential histogram mapping functions
1 participant