Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview: Statsdreceiver using exponential histogram #6666

Closed
wants to merge 13 commits into from

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Dec 8, 2021

Description: This is a preview implementation of the OTLP v0.11 exponential histogram being used as an alternative for the aggregation of histogram/timing measurements in the statsd receiver.

Depends on open-telemetry/opentelemetry-go#2393

Link to tracking Issue: #5742

Testing:
(I am having trouble writing tests for this code because it depends on unmerged code in the OTel-Go repository.)

Documentation: TODO

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 16, 2021
@codeboten codeboten removed the Stale label Dec 21, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2022

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 5, 2022
@jpkrohling jpkrohling removed the Stale label Jan 5, 2022
@jpkrohling
Copy link
Member

@jmacd this is still in progress, right?

@jmacd
Copy link
Contributor Author

jmacd commented Jan 5, 2022

Yes, this is in progress and depends on open-telemetry/opentelemetry-go#2393 merging first. I just gave a demo of this code running for my co-workers :-)

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 20, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2022

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Feb 4, 2022
@jmacd
Copy link
Contributor Author

jmacd commented Feb 5, 2022

I've been asked about this PR recently, opening it to keep people aware it's coming.

@jmacd jmacd reopened this Feb 5, 2022
@github-actions github-actions bot removed the Stale label Feb 6, 2022
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Feb 20, 2022
@jmacd jmacd removed the Stale label Feb 28, 2022
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Mar 15, 2022
@jmacd
Copy link
Contributor Author

jmacd commented Mar 15, 2022

I will re-open eventually.

@jmacd jmacd closed this Mar 15, 2022
@hardproblems
Copy link
Contributor

@jmacd any updates on this? Would love to see this get merged!

@jmacd
Copy link
Contributor Author

jmacd commented Jul 28, 2022

@hardproblems will you please review the code in this PR: open-telemetry/opentelemetry-go#3022
Anyone interested in Statsd receiver support for exponential histogram, please do the same. 😀

@jmacd
Copy link
Contributor Author

jmacd commented Jul 28, 2022

In a week or two, I will re-open this PR targetting the new data structure, which is available elsewhere in the meanwhile:
https://github.com/lightstep/otel-launcher-go/tree/main/lightstep/sdk/metric/aggregator/histogram/structure

@jmacd
Copy link
Contributor Author

jmacd commented Aug 4, 2022

Replaced by #12951

povilasv referenced this pull request in coralogix/opentelemetry-collector-contrib Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants