[receiver/statsd] Add an exponential histogram option #12951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor-contrib into jmacd/statsd_receiver
mx-psi
previously requested changes
Aug 4, 2022
mx-psi
changed the title
…tor-contrib into jmacd/statsd_receiver
|
This probably needs a rebase |
…tor-contrib into jmacd/statsd_receiver
…tor-contrib into jmacd/statsd_receiver
codeboten
reviewed
Aug 9, 2022
…tor-contrib into jmacd/statsd_receiver
|
Will leave this in draft until the testbed refactoring is complete. |
…tor-contrib into jmacd/statsd_receiver
|
This PR has been updated to use a new, separate copy of Lightstep's OTel exponential histogram mapping functions and data structure. Please take another look! |
mx-psi
reviewed
Oct 7, 2022
jmacd
commented
Oct 12, 2022
…tor-contrib into jmacd/statsd_receiver
|
Updated for v0.62.0. |
mx-psi
approved these changes
Oct 13, 2022
There was a problem hiding this comment.
LGTM, my only pending question is #12951 (comment) (also one small thing missing from the v0.62.0 bump).
I will merge after you reply @jmacd if @codeboten has no further comments
Co-authored-by: Pablo Baeyens <[email protected]>
mx-psi
reviewed
Oct 13, 2022
codeboten
approved these changes
Oct 14, 2022
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
…#12951) Adds a "histogram" option to enable the OTLP v0.11 auto-scaling exponential histogram aggregator for Timing and Histogram measurements. Co-authored-by: Pablo Baeyens <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds a "histogram" option to enable the OTLP v0.11 auto-scaling exponential histogram aggregator for Timing and Histogram measurements.
This uses the Histogram mapping functions and data structure implemented in github.com/lightstep/go-expohisto.
The same mapping functions and data structure are pending as for OTel-Go (e.g., open-telemetry/opentelemetry-go#3022); if OTel-Go agrees to expose these APIs, this module can be updated to use it directly, see:
open-telemetry/opentelemetry-go#3169
open-telemetry/opentelemetry-go#3170
Link to tracking Issue:
Fixes #5742
Testing: New tests added.
Documentation: README.md updated with examples including histogram configuration.