Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resources.Azure] Rename AddAppServiceDetector to AddAzureAppServiceDetector #1883

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

joegoldman2
Copy link
Contributor

Fixes #1874.

For significant contributions please make sure you have completed the following items:

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.94%. Comparing base (71655ce) to head (707c208).
Report is 301 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1883      +/-   ##
==========================================
+ Coverage   73.91%   77.94%   +4.02%     
==========================================
  Files         267        6     -261     
  Lines        9615      136    -9479     
==========================================
- Hits         7107      106    -7001     
+ Misses       2508       30    -2478     
Flag Coverage Δ
unittests-Resources.Azure 77.94% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
....Resources.Azure/AzureResourceBuilderExtensions.cs 0.00% <ø> (ø)

... and 272 files with indirect coverage changes

Copy link
Contributor

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose that readme should also be updated together with chabgelog

@Kielek Kielek merged commit 39a7818 into open-telemetry:main Jun 12, 2024
57 checks passed
@joegoldman2 joegoldman2 deleted the fix/1874 branch June 12, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Resources.Azure] Rename AddAppServiceDetector to AddAzureAppServiceDetector
5 participants