Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resources.Azure] Rename AddAppServiceDetector to AddAzureAppServiceDetector #1883

Merged
merged 3 commits into from
Jun 12, 2024
+8 −4
Merged

[Resources.Azure] Rename AddAppServiceDetector to AddAzureAppServiceDetector #1883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c886d7
[Resources.Azure] Rename AddAppServiceDetector to AddAzureAppServiceD…
joegoldman2 Jun 12, 2024
fd19fae
Update CHANGELOG and README
joegoldman2 Jun 12, 2024
707c208
Merge branch 'main' into fix/1874
joegoldman2 Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/OpenTelemetry.Resources.Azure/.publicApi/PublicAPI.Unshipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
OpenTelemetry.Resources.AzureResourceBuilderExtensions
static OpenTelemetry.Resources.AzureResourceBuilderExtensions.AddAppServiceDetector(this OpenTelemetry.Resources.ResourceBuilder! builder) -> OpenTelemetry.Resources.ResourceBuilder!
static OpenTelemetry.Resources.AzureResourceBuilderExtensions.AddAzureAppServiceDetector(this OpenTelemetry.Resources.ResourceBuilder! builder) -> OpenTelemetry.Resources.ResourceBuilder!
static OpenTelemetry.Resources.AzureResourceBuilderExtensions.AddAzureVMDetector(this OpenTelemetry.Resources.ResourceBuilder! builder) -> OpenTelemetry.Resources.ResourceBuilder!
static OpenTelemetry.Resources.AzureResourceBuilderExtensions.AddAzureContainerAppsDetector(this OpenTelemetry.Resources.ResourceBuilder! builder) -> OpenTelemetry.Resources.ResourceBuilder!
4 changes: 2 additions & 2 deletions src/OpenTelemetry.Resources.Azure/AzureResourceBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ namespace OpenTelemetry.Resources;
public static class AzureResourceBuilderExtensions
{
/// <summary>
/// Enables Azure AppService resource detector.
/// Enables Azure App Service resource detector.
/// </summary>
/// <param name="builder"><see cref="ResourceBuilder" /> being configured.</param>
/// <returns>The instance of <see cref="ResourceBuilder" /> being configured.</returns>
public static ResourceBuilder AddAppServiceDetector(this ResourceBuilder builder)
public static ResourceBuilder AddAzureAppServiceDetector(this ResourceBuilder builder)
{
Guard.ThrowIfNull(builder);
return builder.AddDetector(new AppServiceResourceDetector());
Expand Down
4 changes: 4 additions & 0 deletions src/OpenTelemetry.Resources.Azure/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

* **Breaking Change**: Renamed method from `AddAppServiceDetector`
to `AddAzureAppServiceDetector`.
([#1883](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1883))

## 1.0.0-beta.7

Released 2024-Jun-04
Expand Down
2 changes: 1 addition & 1 deletion src/OpenTelemetry.Resources.Azure/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ using OpenTelemetry.Resources;

var tracerProvider = Sdk.CreateTracerProviderBuilder()
// other configurations
.ConfigureResource(resource => resource.AddAppServiceDetector())
.ConfigureResource(resource => resource.AddAzureAppServiceDetector())
.Build();
```

Expand Down
Loading