Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resources.Azure] Rename AddAppServiceDetector to AddAzureAppServiceDetector #1874

Closed
joegoldman2 opened this issue Jun 10, 2024 · 1 comment · Fixed by #1883
Closed

[Resources.Azure] Rename AddAppServiceDetector to AddAzureAppServiceDetector #1874

joegoldman2 opened this issue Jun 10, 2024 · 1 comment · Fixed by #1883
Labels
comp:resources.azure Things related to OpenTelemetry.Resources.Azure

Comments

@joegoldman2
Copy link
Contributor

I wonder if the method ResourceBuilder.AddAppServiceDetector should be renamed to AddAzureAppServiceDetector to follow the naming convention of other methods which begin with AddAzure (like AddAzureContainerAppsDetector).

namespace OpenTelemetry.Resources;

public static class AzureResourceBuilderExtensions
{
-    public static ResourceBuilder AddAppServiceDetector(this ResourceBuilder builder);
+    public static ResourceBuilder AddAzureAppServiceDetector(this ResourceBuilder builder);
}

This package is still unstable, so renaming is possible.

@vishweshbankwar
Copy link
Member

AddAzureAppServiceDetector sounds good to me. @joegoldman2 - Would you like to submit the PR? cc: @rajkumar-rangaraj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:resources.azure Things related to OpenTelemetry.Resources.Azure
Projects
None yet
2 participants