Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add linux-arm builds to releaser #146

Closed
wants to merge 3 commits into from

Conversation

blumamir
Copy link
Member

@blumamir blumamir commented Jun 4, 2022

Fixes #105 . More context and discussions can be read in the issue.

This adds linux-arm builds to the collector and collector contrib, so they can be published to docker hub and consumed on raspberry pi which is running armv7.

This PR follows another PR for adding this architecture to the CI testing in collector repo here. For contrib, this architecture is also tested in CI here

I added the support by following the way it is done for other os-arch, so please review thoroughly as I have little experience with these tools.

Again, thank you @mx-psi for pointing me to the right places :)

@blumamir blumamir requested review from a team and djaglowski June 4, 2022 06:02
@blumamir blumamir mentioned this pull request Jun 4, 2022
@blumamir blumamir changed the title add linux-arm builds to releases add linux-arm builds to releaser Jun 4, 2022
@blumamir
Copy link
Member Author

blumamir commented Jun 4, 2022

CI fails with:

format=rpm package=otelcol-contrib
   •calculating checksums
   •docker images
      • building docker image    image=otel/opentelemetry-collector-contrib:0.52.0-SNAPSHOT-6eeeed8-arm
      • building docker image    image=otel/opentelemetry-collector:0.52.0-SNAPSHOT-6eeeed8-arm
      • building docker image    image=otel/opentelemetry-collector:0.52.0-SNAPSHOT-6eeeed8-386
      • building docker image    image=otel/opentelemetry-collector:0.52.0-SNAPSHOT-6eeeed8-amd64
      • building docker image    image=otel/opentelemetry-collector:0.52.0-SNAPSHOT-6eeeed8-arm64
      • building docker image    image=otel/opentelemetry-collector-contrib:0.52.0-SNAPSHOT-6eeeed8-386
      • building docker image    image=otel/opentelemetry-collector-contrib:0.52.0-SNAPSHOT-6eeeed8-amd64
      • building docker image    image=otel/opentelemetry-collector-contrib:0.52.0-SNAPSHOT-6eeeed8-arm64
   ⨯release failed after 2054.19serror=docker build failed: failed to build otel/opentelemetry-collector-contrib:0.52.0-SNAPSHOT-6eeeed8-arm: exit status 1: #1 [internal] load build definition from Dockerfile

Any tips on how to debug this issue?

@mx-psi
Copy link
Member

mx-psi commented Jun 7, 2022

Can you add --debug here?

args: --snapshot --rm-dist --timeout 1h

It's hard to know what is happening with the current output

@jpkrohling
Copy link
Member

On a Linux machine (and presumably others, like Mac), you can run "goreleaser" locally, which would produce better output and log files. Let me know if you can't figure out how to do it following goreleaser's documentation (and this repo's).

@mx-psi
Copy link
Member

mx-psi commented Aug 3, 2022

Modifying the QEMU setup will probably fix the issue (see #173)

@fidesachates
Copy link

What's the best way to make progress here? @blumamir do you plan on continuing or should someone else carry on? Seems like @mx-psi 's suggestion is an easy one to try.

- configs/otelcol.yaml
build_flag_templates:
- --pull
- --platform=linux/arm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have arm64 or arm32, I don't believe arm by itself is a valid architecture.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the docshttps://github.com/docker-library/official-images#architectures-other-than-amd64 it looks like it should be set to arm32v7and arm64v8 ?

@Wal8800
Copy link
Contributor

Wal8800 commented May 17, 2023

Hey @blumamir are you looking to finish this pull request? I'm also interested in otel-contrib release for armv7.

I think for --platform argument, it should be linux/arm/v7 as that's what we have been using to build docker image for the raspberry pi.

@mx-psi
Copy link
Member

mx-psi commented Jul 21, 2023

Closing in favor of #349

@mx-psi mx-psi closed this Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

distribution for arm7
6 participants