Add arm32v7 to release configurations #349

Wal8800 · 2023-06-03T01:14:09Z

Summary

This pull request is looking to introduce arm32v7 release for otelcol and otel-contrib distribution.

The pull request builds on top of the changes in #146, I changed --platform to linux/arm/v7 to hopefully fix the CI build error.

Manual Tests

Able to build the new arm docker image locally with goreleaser release --clean --snapshot

linux-foundation-easycla · 2023-06-03T01:14:13Z

The committers listed above are authorized under a signed CLA.

✅ login: Wal8800 / name: John Law (4f12ea6, 5016a8f, 145f6ed, e2cf480)

Wal8800 · 2023-06-04T02:25:22Z

cmd/goreleaser/internal/configure.go

+			case ArmArch:
+				for _, vers := range ArmVersions {
+					r = append(r, DockerImage(imagePrefixes, dist, arch, vers))
+				}
+			default:
+				r = append(r, DockerImage(imagePrefixes, dist, arch, ""))
+			}


Initially, for including the optional arm version, I thought about creating a new configuration type to default the arm version to empty string. For example:

type DockerImageConfig struct { ImagePrefixes []string Dist string Arch string ArmVersion string }

Then in the future we can add more optional values such as AMD64 versions. However, it seems like that's more complicated for the current usage, that is, in most cases we only pass around 3 values (imagePrefixes, dist and arch). So for now, I opted to add new argument to DockerImages instead. Happy to change it other suggestions/alternatives.

jpkrohling · 2023-06-07T18:44:31Z

Can you please confirm we have this arch in the CI for both core and contrib repositories?

Wal8800 · 2023-06-09T23:14:34Z

Great question!

Currently, the CI for both core and contrib repositories specify arm in the architecture list but they don't specify the GOARM environment variable. This means it's using the default GOARM value. Interestingly, the default GOARM value depends on the platform that we are building on and there are changes to default to 7 for all non-arm systems in the upcoming golang version.

I'll try to add GOARM in the CI for both core and contrib so we can be explicit about the GOARM values. I will report back here once I completed the changes in the other repositories.

jpkrohling · 2023-06-14T19:02:59Z

Thank you. In the meantime, I'm converting this to draft, to prevent it from being inadvertently merged.

Wal8800 · 2023-07-05T01:21:26Z

Ready for re-review.

Updated the ci in core and contrib to specifically for armv7:

[ci] Specify 7 as arm version for arm build in CI opentelemetry-collector-contrib#23436
[ci] Specify 7 as arm version for arm build in CI opentelemetry-collector#7873

Also, pulled in the latest main branch and rebase the pull request changes.

jpkrohling · 2023-07-05T12:51:21Z

CI started

Wal8800 · 2023-07-05T21:08:43Z

Sorry, I didn't realise I need to update the list of GOARCH as we splitted the builds by arch. Now, I have updated the GOARCH list to include arm and modified the qemu setup set to include linux/arm/v7. Can we trigger the CI build again please.

jpkrohling · 2023-07-07T19:35:49Z

CI started.

Wal8800 · 2023-07-07T22:33:19Z

The docker tag can't have / so I made some changes to remove them. Ran goreleaser release --snapshot --clean --timeout 2h locally to make sure it works this time.

Command output:

click here to see

  • starting release...
  • loading config file                              file=.goreleaser.yaml
  • loading environment variables
  • getting and validating git state
    • ignoring errors because this is a snapshot     error=git doesn't contain any tags. Either add a tag or use --snapshot
    • building...                                    commit=145f6ed8620be1ef2d83c026ab58b0790038f4b9 latest tag=v0.0.0
    • pipe skipped                                   reason=disabled during snapshot mode
  • parsing tag
  • setting defaults
  • snapshotting
    • building snapshot...                           version=0.0.0-SNAPSHOT-145f6ed
  • checking distribution directory
    • cleaning dist
  • loading go mod information
  • build prerequisites
  • writing effective config file
    • writing                                        config=dist/config.yaml
  • building binaries
    • building                                       binary=dist/otelcol_linux_arm64/otelcol
    • building                                       binary=dist/otelcol_linux_386/otelcol
    • building                                       binary=dist/otelcol_darwin_amd64_v1/otelcol
    • building                                       binary=dist/otelcol_darwin_arm64/otelcol
    • building                                       binary=dist/otelcol_linux_amd64_v1/otelcol
    • building                                       binary=dist/otelcol_linux_arm_7/otelcol
    • building                                       binary=dist/otelcol_linux_ppc64le/otelcol
    • building                                       binary=dist/otelcol_windows_386/otelcol.exe
    • building                                       binary=dist/otelcol_windows_amd64_v1/otelcol.exe
    • building                                       binary=dist/otelcol-contrib_darwin_amd64_v1/otelcol-contrib
    • building                                       binary=dist/otelcol-contrib_darwin_arm64/otelcol-contrib
    • building                                       binary=dist/otelcol-contrib_linux_386/otelcol-contrib
    • building                                       binary=dist/otelcol-contrib_linux_amd64_v1/otelcol-contrib
    • building                                       binary=dist/otelcol-contrib_linux_arm_7/otelcol-contrib
    • building                                       binary=dist/otelcol-contrib_linux_arm64/otelcol-contrib
    • building                                       binary=dist/otelcol-contrib_linux_ppc64le/otelcol-contrib
    • building                                       binary=dist/otelcol-contrib_windows_386/otelcol-contrib.exe
    • building                                       binary=dist/otelcol-contrib_windows_amd64_v1/otelcol-contrib.exe
    • took: 46s
  • archives
    • creating                                       archive=dist/otelcol_0.0.0-SNAPSHOT-145f6ed_darwin_amd64.tar.gz
    • creating                                       archive=dist/otelcol_0.0.0-SNAPSHOT-145f6ed_linux_amd64.tar.gz
    • creating                                       archive=dist/otelcol_0.0.0-SNAPSHOT-145f6ed_linux_ppc64le.tar.gz
    • creating                                       archive=dist/otelcol_0.0.0-SNAPSHOT-145f6ed_windows_amd64.tar.gz
    • creating                                       archive=dist/otelcol_0.0.0-SNAPSHOT-145f6ed_darwin_arm64.tar.gz
    • creating                                       archive=dist/otelcol_0.0.0-SNAPSHOT-145f6ed_linux_386.tar.gz
    • creating                                       archive=dist/otelcol_0.0.0-SNAPSHOT-145f6ed_linux_arm64.tar.gz
    • creating                                       archive=dist/otelcol_0.0.0-SNAPSHOT-145f6ed_windows_386.tar.gz
    • creating                                       archive=dist/otelcol_0.0.0-SNAPSHOT-145f6ed_linux_armv7.tar.gz
    • creating                                       archive=dist/otelcol-contrib_0.0.0-SNAPSHOT-145f6ed_linux_386.tar.gz
    • creating                                       archive=dist/otelcol-contrib_0.0.0-SNAPSHOT-145f6ed_darwin_amd64.tar.gz
    • creating                                       archive=dist/otelcol-contrib_0.0.0-SNAPSHOT-145f6ed_linux_ppc64le.tar.gz
    • creating                                       archive=dist/otelcol-contrib_0.0.0-SNAPSHOT-145f6ed_darwin_arm64.tar.gz
    • creating                                       archive=dist/otelcol-contrib_0.0.0-SNAPSHOT-145f6ed_windows_386.tar.gz
    • creating                                       archive=dist/otelcol-contrib_0.0.0-SNAPSHOT-145f6ed_windows_amd64.tar.gz
    • creating                                       archive=dist/otelcol-contrib_0.0.0-SNAPSHOT-145f6ed_linux_armv7.tar.gz
    • creating                                       archive=dist/otelcol-contrib_0.0.0-SNAPSHOT-145f6ed_linux_arm64.tar.gz
    • creating                                       archive=dist/otelcol-contrib_0.0.0-SNAPSHOT-145f6ed_linux_amd64.tar.gz
    • took: 32s
  • linux packages
    • creating                                       package=otelcol format=apk arch=ppc64le file=dist/otelcol_0.0.0-SNAPSHOT-145f6ed_linux_ppc64le.apk
    • creating                                       package=otelcol format=deb arch=386 file=dist/otelcol_0.0.0-SNAPSHOT-145f6ed_linux_386.deb
    • creating                                       package=otelcol format=apk arch=386 file=dist/otelcol_0.0.0-SNAPSHOT-145f6ed_linux_386.apk
    • creating                                       package=otelcol format=apk arch=arm7 file=dist/otelcol_0.0.0-SNAPSHOT-145f6ed_linux_armv7.apk
    • creating                                       package=otelcol format=apk arch=arm64 file=dist/otelcol_0.0.0-SNAPSHOT-145f6ed_linux_arm64.apk
    • creating                                       package=otelcol format=apk arch=amd64v1 file=dist/otelcol_0.0.0-SNAPSHOT-145f6ed_linux_amd64.apk
    • creating                                       package=otelcol format=deb arch=ppc64le file=dist/otelcol_0.0.0-SNAPSHOT-145f6ed_linux_ppc64le.deb
    • creating                                       package=otelcol format=deb arch=arm64 file=dist/otelcol_0.0.0-SNAPSHOT-145f6ed_linux_arm64.deb
    • creating                                       package=otelcol format=deb arch=amd64v1 file=dist/otelcol_0.0.0-SNAPSHOT-145f6ed_linux_amd64.deb
    • creating                                       package=otelcol format=deb arch=arm7 file=dist/otelcol_0.0.0-SNAPSHOT-145f6ed_linux_armv7.deb
    • creating                                       package=otelcol format=rpm arch=arm64 file=dist/otelcol_0.0.0-SNAPSHOT-145f6ed_linux_arm64.rpm
    • creating                                       package=otelcol format=rpm arch=amd64v1 file=dist/otelcol_0.0.0-SNAPSHOT-145f6ed_linux_amd64.rpm
    • creating                                       package=otelcol format=rpm arch=arm7 file=dist/otelcol_0.0.0-SNAPSHOT-145f6ed_linux_armv7.rpm
    • creating                                       package=otelcol format=rpm arch=386 file=dist/otelcol_0.0.0-SNAPSHOT-145f6ed_linux_386.rpm
    • creating                                       package=otelcol format=rpm arch=ppc64le file=dist/otelcol_0.0.0-SNAPSHOT-145f6ed_linux_ppc64le.rpm
    • creating                                       package=otelcol-contrib format=apk arch=arm7 file=dist/otelcol-contrib_0.0.0-SNAPSHOT-145f6ed_linux_armv7.apk
    • creating                                       package=otelcol-contrib format=apk arch=amd64v1 file=dist/otelcol-contrib_0.0.0-SNAPSHOT-145f6ed_linux_amd64.apk
    • creating                                       package=otelcol-contrib format=apk arch=arm64 file=dist/otelcol-contrib_0.0.0-SNAPSHOT-145f6ed_linux_arm64.apk
    • creating                                       package=otelcol-contrib format=deb arch=arm7 file=dist/otelcol-contrib_0.0.0-SNAPSHOT-145f6ed_linux_armv7.deb
    • creating                                       package=otelcol-contrib format=apk arch=386 file=dist/otelcol-contrib_0.0.0-SNAPSHOT-145f6ed_linux_386.apk
    • creating                                       package=otelcol-contrib format=apk arch=ppc64le file=dist/otelcol-contrib_0.0.0-SNAPSHOT-145f6ed_linux_ppc64le.apk
    • creating                                       package=otelcol-contrib format=deb arch=386 file=dist/otelcol-contrib_0.0.0-SNAPSHOT-145f6ed_linux_386.deb
    • creating                                       package=otelcol-contrib format=deb arch=amd64v1 file=dist/otelcol-contrib_0.0.0-SNAPSHOT-145f6ed_linux_amd64.deb
    • creating                                       package=otelcol-contrib format=deb arch=ppc64le file=dist/otelcol-contrib_0.0.0-SNAPSHOT-145f6ed_linux_ppc64le.deb
    • creating                                       package=otelcol-contrib format=deb arch=arm64 file=dist/otelcol-contrib_0.0.0-SNAPSHOT-145f6ed_linux_arm64.deb
    • creating                                       package=otelcol-contrib format=rpm arch=arm7 file=dist/otelcol-contrib_0.0.0-SNAPSHOT-145f6ed_linux_armv7.rpm
    • creating                                       package=otelcol-contrib format=rpm arch=386 file=dist/otelcol-contrib_0.0.0-SNAPSHOT-145f6ed_linux_386.rpm
    • creating                                       package=otelcol-contrib format=rpm arch=amd64v1 file=dist/otelcol-contrib_0.0.0-SNAPSHOT-145f6ed_linux_amd64.rpm
    • creating                                       package=otelcol-contrib format=rpm arch=ppc64le file=dist/otelcol-contrib_0.0.0-SNAPSHOT-145f6ed_linux_ppc64le.rpm
    • creating                                       package=otelcol-contrib format=rpm arch=arm64 file=dist/otelcol-contrib_0.0.0-SNAPSHOT-145f6ed_linux_arm64.rpm
    • took: 9s
  • calculating checksums
    • took: 1s
  • docker images
    • building docker image                          image=otel/opentelemetry-collector:0.0.0-SNAPSHOT-145f6ed-386
    • building docker image                          image=otel/opentelemetry-collector:0.0.0-SNAPSHOT-145f6ed-arm64
    • building docker image                          image=otel/opentelemetry-collector:0.0.0-SNAPSHOT-145f6ed-ppc64le
    • building docker image                          image=otel/opentelemetry-collector-contrib:0.0.0-SNAPSHOT-145f6ed-386
    • building docker image                          image=otel/opentelemetry-collector:0.0.0-SNAPSHOT-145f6ed-armv7
    • building docker image                          image=otel/opentelemetry-collector:0.0.0-SNAPSHOT-145f6ed-amd64
    • building docker image                          image=otel/opentelemetry-collector-contrib:0.0.0-SNAPSHOT-145f6ed-amd64
    • building docker image                          image=otel/opentelemetry-collector-contrib:0.0.0-SNAPSHOT-145f6ed-armv7
    • building docker image                          image=otel/opentelemetry-collector-contrib:0.0.0-SNAPSHOT-145f6ed-arm64
    • building docker image                          image=otel/opentelemetry-collector-contrib:0.0.0-SNAPSHOT-145f6ed-ppc64le
    • took: 2m36s
  • storing release metadata
    • writing                                        file=dist/artifacts.json
    • writing                                        file=dist/metadata.json
  • release succeeded after 4m3s
  • thanks for using goreleaser!

jpkrohling · 2023-07-10T18:46:49Z

CI started

jpkrohling · 2023-07-17T17:47:16Z

@MovieStoreGuy , would you like to take a final look at this one as well?

jpkrohling · 2023-07-20T14:15:01Z

I'm merging this, but I'd still appreciate an OK from @MovieStoreGuy after the merge.

Wal8800 requested review from a team and MovieStoreGuy June 3, 2023 01:14

MovieStoreGuy self-assigned this Jun 3, 2023

Wal8800 commented Jun 4, 2023

View reviewed changes

jpkrohling marked this pull request as draft June 14, 2023 19:02

Wal8800 added 2 commits July 5, 2023 13:18

Add arm32v7 to release configurations

4f12ea6

Update config generator to allow for arm version

5016a8f

Wal8800 marked this pull request as ready for review July 5, 2023 01:21

Update list of goarch builds with arm

145f6ed

Fix docker tag

e2cf480

jpkrohling approved these changes Jul 17, 2023

View reviewed changes

jpkrohling merged commit 0450858 into open-telemetry:main Jul 20, 2023

mx-psi mentioned this pull request Jul 21, 2023

add linux-arm builds to releaser #146

Closed

Wal8800 deleted the armv7-release branch July 21, 2023 22:36

mx-psi mentioned this pull request Sep 26, 2023

Find owners for the linux/arm platform open-telemetry/opentelemetry-collector#8527

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add arm32v7 to release configurations #349

Add arm32v7 to release configurations #349

Wal8800 commented Jun 3, 2023 •

edited

Loading

linux-foundation-easycla bot commented Jun 3, 2023 •

edited

Loading

Wal8800 Jun 4, 2023 •

edited

Loading

jpkrohling commented Jun 7, 2023

Wal8800 commented Jun 9, 2023 •

edited

Loading

jpkrohling commented Jun 14, 2023

Wal8800 commented Jul 5, 2023 •

edited

Loading

jpkrohling commented Jul 5, 2023

Wal8800 commented Jul 5, 2023

jpkrohling commented Jul 7, 2023

Wal8800 commented Jul 7, 2023 •

edited

Loading

jpkrohling commented Jul 10, 2023

jpkrohling commented Jul 17, 2023

jpkrohling commented Jul 20, 2023

Add arm32v7 to release configurations #349

Add arm32v7 to release configurations #349

Conversation

Wal8800 commented Jun 3, 2023 • edited Loading

Summary

Manual Tests

linux-foundation-easycla bot commented Jun 3, 2023 • edited Loading

Wal8800 Jun 4, 2023 • edited Loading

Choose a reason for hiding this comment

jpkrohling commented Jun 7, 2023

Wal8800 commented Jun 9, 2023 • edited Loading

jpkrohling commented Jun 14, 2023

Wal8800 commented Jul 5, 2023 • edited Loading

jpkrohling commented Jul 5, 2023

Wal8800 commented Jul 5, 2023

jpkrohling commented Jul 7, 2023

Wal8800 commented Jul 7, 2023 • edited Loading

jpkrohling commented Jul 10, 2023

jpkrohling commented Jul 17, 2023

jpkrohling commented Jul 20, 2023

Wal8800 commented Jun 3, 2023 •

edited

Loading

linux-foundation-easycla bot commented Jun 3, 2023 •

edited

Loading

Wal8800 Jun 4, 2023 •

edited

Loading

Wal8800 commented Jun 9, 2023 •

edited

Loading

Wal8800 commented Jul 5, 2023 •

edited

Loading

Wal8800 commented Jul 7, 2023 •

edited

Loading