Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distribution for arm7 #105

Open
blumamir opened this issue Apr 27, 2022 · 7 comments
Open

distribution for arm7 #105

blumamir opened this issue Apr 27, 2022 · 7 comments
Labels
help wanted Extra attention is needed

Comments

@blumamir
Copy link
Member

Hi, I want to use the collector on Raspberry PI with docker, and was not able to find a relevant image in dockerhub to use.
Looking at some old issues and PRs it seems to be removed intentionally.
Was wondering if there are plans to support it any time soon

@jpkrohling
Copy link
Member

I think we had it at some time but had to remove it due to build issues with a component. Would you be able to try to build the collector for arm7 and report back? If it works and is part of the continuous testing for the core and contrib repos, we could certainly add an official build for it.

@blumamir
Copy link
Member Author

I think we had it at some time but had to remove it due to build issues with a component. Would you be able to try to build the collector for arm7 and report back? If it works and is part of the continuous testing for the core and contrib repos, we could certainly add an official build for it.

Thanks for the reply
Unfortunately, I have no background in GO and have too much on my plate right now to familiarize myself with the build scripts of the collector.
I will keep this issue here, and maybe someone will pick it up 🤷‍♂️

@mx-psi
Copy link
Member

mx-psi commented May 2, 2022

This is blocked by open-telemetry/opentelemetry-collector-contrib#8544, it should be easy to fix if you want to try, even if you don't know Go! For comparison this is what it took on the core distro: open-telemetry/opentelemetry-collector#5142

@mx-psi mx-psi added the help wanted Extra attention is needed label May 3, 2022
@mx-psi
Copy link
Member

mx-psi commented Jun 3, 2022

#144 will revert the PR that removed this (nope, I got confused)

@blumamir
Copy link
Member Author

blumamir commented Jun 3, 2022

#144 will revert the PR that removed this

Thanks for the update. This PR seems to be adding 386, will it also support raspberry pi that is running arm v7?

@mx-psi
Copy link
Member

mx-psi commented Jun 3, 2022

#144 will revert the PR that removed this

Thanks for the update. This PR seems to be adding 386, will it also support raspberry pi that is running arm v7?

Oh, of course, I got confused by the "Looking at some old issues and PRs it seems to be removed intentionally." 🤦 This will add back support for x86 32 bits, sorry to get your hopes up.

Support for armv7 has not been available since #43 because at some point contrib was not buildable on that architecture. We currently build on armv7 on the contrib repo (see here) so we could add it here. The steps to do it would be to:

  • add a test step at collector core (here)
  • Add it to the list or architectures on this repository on goreleaser/configure.go

Both are 1-line PRs and I see no reason to reject them, so you are welcome to contribute :)

@blumamir
Copy link
Member Author

blumamir commented Jun 4, 2022

Both are 1-line PRs and I see no reason to reject them, so you are welcome to contribute :)

Created PR in #146 . Thanks for all the help and guidness

@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Jul 16, 2024
@dosubot dosubot bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 23, 2024
@dosubot dosubot bot removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Jul 23, 2024
@mx-psi mx-psi reopened this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants