Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests for Issue-19066 #19243

Closed

Conversation

rushikesh1799
Copy link
Contributor

Fixes #19066

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Ashish8689 and others added 10 commits January 3, 2025 10:09
…-metadata#17918)

* supported glossary table column resizable

* code cleanup

* fix the column resizing affecting other column width

* fix the playwright failure around the glossary due to re-sizable added
…adata#19149)

* feat(ui): show count with schema tab for table details page

* fix active state for tab

* fix tests and cover topic details page

* add missing isActive check
* modify and fix some lineage issues

* minor fix

* restrict the node removal in case any error occured

* fix flaky playwright test

* userDetail flaky fix
When using using the assumeRole connection option with jobs involving
AWS services, the default 1 hour of boto might not cut it and the job
fails, one way of solving this is to refresh the credentials when they
expire, this ensures there is always valid credentials for the job
regardless for how long it runs.

Co-authored-by: Abdallah Serghine <[email protected]>
Co-authored-by: IceS2 <[email protected]>
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

1 similar comment
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants