-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): show count with schema tab for table details page #19149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
safe to test
Add this label to run secure Github workflows on PRs
UI
UI specific issues
labels
Dec 20, 2024
ulixius9
previously approved these changes
Dec 20, 2024
@chirag-madlani can you check around the badge active background color, it's different from the other we have at other places |
chirag-madlani
had a problem deploying
to
test
December 20, 2024 07:05 — with
GitHub Actions
Failure
chirag-madlani
had a problem deploying
to
test
December 20, 2024 07:05 — with
GitHub Actions
Failure
@Ashish8689 updated |
Ashish8689
previously approved these changes
Dec 20, 2024
ShaileshParmar11
approved these changes
Jan 2, 2025
Quality Gate passed for 'open-metadata-ui'Issues Measures |
Ashish8689
approved these changes
Jan 2, 2025
chirag-madlani
added a commit
that referenced
this pull request
Jan 3, 2025
* feat(ui): show count with schema tab for table details page * fix active state for tab * fix tests and cover topic details page * add missing isActive check (cherry picked from commit cdef12c)
chirag-madlani
added a commit
that referenced
this pull request
Jan 3, 2025
* feat(ui): show count with schema tab for table details page * fix active state for tab * fix tests and cover topic details page * add missing isActive check (cherry picked from commit cdef12c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes: show schema count on top of tab
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>