Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): show count with schema tab for table details page #19149

Merged
merged 5 commits into from
Jan 3, 2025

Conversation

chirag-madlani
Copy link
Collaborator

@chirag-madlani chirag-madlani commented Dec 20, 2024

Describe your changes:

Fixes: show schema count on top of tab

Screenshot 2024-12-20 at 12 36 44 PM Screenshot 2025-01-02 at 6 04 53 PM

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

ulixius9
ulixius9 previously approved these changes Dec 20, 2024
@Ashish8689
Copy link
Contributor

Ashish8689 commented Dec 20, 2024

@chirag-madlani can you check around the badge active background color, it's different from the other we have at other places
image

@chirag-madlani
Copy link
Collaborator Author

@chirag-madlani can you check around the badge active background color, it's different from the other we have at other places image

@Ashish8689 updated

Ashish8689
Ashish8689 previously approved these changes Dec 20, 2024
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
64.51% (40586/62912) 40.74% (16251/39888) 43.85% (4914/11206)

Copy link

sonarqubecloud bot commented Jan 2, 2025

@chirag-madlani chirag-madlani merged commit cdef12c into main Jan 3, 2025
16 of 18 checks passed
@chirag-madlani chirag-madlani deleted the fix-schema-count branch January 3, 2025 04:49
chirag-madlani added a commit that referenced this pull request Jan 3, 2025
* feat(ui): show count with schema tab for table details page

* fix active state for tab

* fix tests and cover topic details page

* add missing isActive check

(cherry picked from commit cdef12c)
chirag-madlani added a commit that referenced this pull request Jan 3, 2025
* feat(ui): show count with schema tab for table details page

* fix active state for tab

* fix tests and cover topic details page

* add missing isActive check

(cherry picked from commit cdef12c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants