Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): show count with schema tab for table details page #19149

Merged
merged 5 commits into from
Jan 3, 2025
Merged

feat(ui): show count with schema tab for table details page #19149

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
36ff97a
feat(ui): show count with schema tab for table details page
chirag-madlani Dec 20, 2024
67bf06c
fix active state for tab
chirag-madlani Dec 20, 2024
cf7f5f4
Merge branch 'main' into fix-schema-count
chirag-madlani Jan 2, 2025
a6f4364
fix tests and cover topic details page
chirag-madlani Jan 2, 2025
9bebde1
add missing isActive check
chirag-madlani Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/Table.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,4 +86,11 @@ test.describe('Table pagination sorting search scenarios ', () => {

await expect(page.getByTestId('search-error-placeholder')).toBeVisible();
});


test('Table page should show schema tab with count', async ({ page }) => {
await table1.visitEntityPage(page);

await expect(page.getByRole('tab', { name: 'Schema' })).toContainText('4');
});
});
9 changes: 8 additions & 1 deletion openmetadata-ui/src/main/resources/ui/src/utils/TableUtils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,7 +753,14 @@ export const getTableDetailPageBaseTabs = ({
}: TableDetailPageTabProps): TabProps[] => {
return [
{
label: <TabsLabel id={EntityTabs.SCHEMA} name={t('label.schema')} />,
label: (
<TabsLabel
count={tableDetails?.columns.length}
id={EntityTabs.SCHEMA}
isActive={activeTab === EntityTabs.SCHEMA}
name={t('label.schema')}
/>
),
chirag-madlani marked this conversation as resolved.
Show resolved Hide resolved
key: EntityTabs.SCHEMA,
children: schemaTab,
},
Expand Down
Loading