Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViewAll() not working with matchAnyTag() and isOwner() conditions #19066

Closed
harshach opened this issue Dec 14, 2024 · 2 comments · Fixed by #19209
Closed

ViewAll() not working with matchAnyTag() and isOwner() conditions #19066

harshach opened this issue Dec 14, 2024 · 2 comments · Fixed by #19209
Assignees

Comments

@harshach
Copy link
Collaborator

ViewAll() not working with matchAnyTag() and isOwner() conditions

@chirag-madlani need someone from UI to handle the tests from playwright

@harshach
Copy link
Collaborator Author

harshach commented Jan 2, 2025

@Prajwal214 check the PR and test it by yourself once.

Tests we need from UI team @chirag

  1. Create a role, with following policy
    1. Data Consumer Role must have viewAll, with isOwner() and/or a matchAnyTag
  2. add logged in ownership to one of the database service, and if you are using matchAnyTag and add one of the tags to Database Service
  3. clicking on the database service will allow user who has the ownership of the service and tag should be able to view
  4. They should be able to see the list of the databases
  5. Repeat the same test across the services
  6. Repeat the similar test for databases, database schemas, containers, apiCollection

@harshach harshach moved this from Platform to In Progress in Release 1.6.2 Jan 5, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Release 1.6.2 Jan 7, 2025
@Prajwal214
Copy link
Contributor

Prajwal214 commented Jan 8, 2025

@Prajwal214 check the PR and test it by yourself once.

Changes look good, ViewAll() is working now with matchAnyTag() and isOwner() conditions.


Steps to Reproduce the Issue -

  • Use the ViewAll privilege with a combination of isOwner() and matchAnyTag().
    Example configuration:
image
  • Under the Database/Schema, we observe that the ViewBasic privilege is applied when the condition is met.
    Screenshot of the privilege:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants