Aiohttp 3.6.2 plus connection leak fix #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arning (aio-libs#3529) (aio-libs#3531) (cherry picked from commit 2d8aa12) Co-authored-by: Goran Cetušić <[email protected]>
(cherry picked from commit aa5cccb) Co-authored-by: Miha Jenko <[email protected]>
aio-libs#3533) (aio-libs#3541) (cherry picked from commit f590bfd) Co-authored-by: Joshu Coats <[email protected]>
…) (aio-libs#3527) (aio-libs#3560) (aio-libs#3565) (cherry picked from commit c3f494f) Co-authored-by: Коренберг Марк <[email protected]>
…ibs#3732) (aio-libs#3735) (cherry picked from commit db80171) Co-authored-by: Mathieu Dugré <[email protected]>
…. (aio-libs#3734) (cherry picked from commit 7846174) Co-authored-by: Gustavo J. A. M. Carneiro <[email protected]>
…r mismatch _keepalive field with __slots__ (aio-libs#3727) (aio-libs#3731) (cherry picked from commit bfb99eb) Co-authored-by: Artem Yushkovskiy <[email protected]> (cherry picked from commit ff1c9de) Co-authored-by: Artem Yushkovskiy <[email protected]>
…atch _keepalive field with __slots__ (aio-libs#3727) (aio-libs#3729) (cherry picked from commit bfb99eb) Co-authored-by: Artem Yushkovskiy <[email protected]>
… (aio-libs#3730) (cherry picked from commit ad2c187) Co-authored-by: fa1l <[email protected]>
…libs#3626) (cherry picked from commit 398b5ba) Co-authored-by: Anders Melchiorsen <[email protected]>
* Fix type hint for tracing Signal sequence content The Signal is instantiated with a TraceConfig object but does not store it in its mutable sequence. Fixed hinting to reflect what is expected to be added as signal handler.
* 🐽 streams: change waiters return value to None This is just a simplifaction. Actually, the value means nothing. * 🐽 stream.readchunk() refactoring (cherry picked from commit 36331ce) Co-authored-by: Коренберг Марк <[email protected]>
) (cherry picked from commit ab0e956) Co-authored-by: Andrew Svetlov <[email protected]>
… (aio-libs#3754) (cherry picked from commit e6cbce3) Co-authored-by: Cong <[email protected]>
…on an empty MultipartWriter (aio-libs#3520) (aio-libs#3756) (cherry picked from commit 0ad5d90) Co-authored-by: Arthur Darcet <[email protected]>
(cherry picked from commit 263fb5d) Co-authored-by: Sviatoslav Sydorenko <[email protected]>
…o-libs#3783) (aio-libs#3784) (cherry picked from commit e54e7cc) Co-authored-by: Harmon <[email protected]>
…equest's data argument (aio-libs#3755) (aio-libs#3786) (cherry picked from commit 9876e29) Co-authored-by: JustAnotherArchivist <[email protected]>
…io-libs#3789) (cherry picked from commit 506c244) Co-authored-by: Samuel Colvin <[email protected]>
…path (aio-libs#3791) (aio-libs#3792) (cherry picked from commit 6b0a651) Co-authored-by: Harmon <[email protected]>
…onnectorError` (aio-libs#4097) (aio-libs#4120) (aio-libs#4121) (cherry picked from commit ac180b1) Co-authored-by: Bryan Kok <[email protected]>
(cherry picked from commit a1a1a53) Co-authored-by: Nick <[email protected]>
…#4133) Given that the `FrozenList` type hint is `Union[List[_T], Iterable[_T]]` the Application middleware type should not restrict to `Sequence` and support all `Iterable` types.. (cherry picked from commit 8475395) Co-authored-by: Stefan T <[email protected]>
…io-libs#4143) The sock_read timeout should apply *per read operation*, but currently applies cumulatively across all reads. Reschedule the timeout each time data is received and add tests to validate that the timeout doesn't interfere with overall reading and correctly catches reads that take too long. Co-authored-by: Martijn Pieters <[email protected]>
|
@vangheem and @lferran seem that new version does not break onna canonica [1], so if you agree the steps that would need to be done will be:
|
|
@pfreixes do we need to re-fork? I notice that we have a lot of conflicts. |
|
Also, do we need to keep forking at this point? |
|
https://github.com/aio-libs/aiohttp/pull/4562/files is the cherry-picked additional fix |
vangheem
approved these changes
Jun 23, 2020
|
As we speak I will override the master branch with this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades to the last stable version of Aiohttp - 3.6.2 tag - plus adds a hotfix which is pending to be reviewed [1] that fixes a bug with a race condition that might leak connections in the client connection pool under some circumstances.
Tests pass in local:
[1] aio-libs#4562