Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc docs fix - background tasks example throws a deprecation warning #3529

Merged
merged 3 commits into from
Jan 13, 2019

Conversation

gcetusic
Copy link
Contributor

@gcetusic gcetusic commented Jan 12, 2019

What do these changes do?

The changes remove some references to event loop in docs as using it is deprecated in aiohttp

Are there changes in behavior for the user?

There are no changes in behaviour, just docs

Related issue number

Fixes #3526

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@codecov-io
Copy link

codecov-io commented Jan 12, 2019

Codecov Report

Merging #3529 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3529      +/-   ##
==========================================
- Coverage   97.94%   97.92%   -0.03%     
==========================================
  Files          44       44              
  Lines        8562     8562              
  Branches     1381     1381              
==========================================
- Hits         8386     8384       -2     
- Misses         71       72       +1     
- Partials      105      106       +1
Impacted Files Coverage Δ
aiohttp/web_fileresponse.py 96.55% <0%> (-1.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c4cb82...bb39f19. Read the comment docs.

@asvetlov asvetlov merged commit 2d8aa12 into aio-libs:master Jan 13, 2019
asvetlov pushed a commit that referenced this pull request Jan 13, 2019
…arning (#3529)

(cherry picked from commit 2d8aa12)

Co-authored-by: Goran Cetušić <[email protected]>
asvetlov added a commit that referenced this pull request Jan 13, 2019
…arning (#3529) (#3531)

(cherry picked from commit 2d8aa12)

Co-authored-by: Goran Cetušić <[email protected]>
@lock
Copy link

lock bot commented Jan 13, 2020

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Jan 13, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 13, 2020
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jan 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aiohttp server Background task loop deprecated
3 participants