Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc docs fix - background tasks example throws a deprecation warning #3529

Merged
merged 3 commits into from
Jan 13, 2019
Merged

misc docs fix - background tasks example throws a deprecation warning #3529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d145c3f
misc docs fix - background tasks example throws a deprecation warning
gcetusic Jan 12, 2019
a3168f1
misc fix - loop not needed for aioredis, uses get_event_loop by default
gcetusic Jan 12, 2019
bb39f19
added doc changelog for issue #3526
gcetusic Jan 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES/3526.doc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Modify documentation for Background Tasks to remove deprecated usage of event loop.
4 changes: 2 additions & 2 deletions docs/web_advanced.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -942,7 +942,7 @@ signal handlers as shown in the example below::

async def listen_to_redis(app):
try:
sub = await aioredis.create_redis(('localhost', 6379), loop=app.loop)
sub = await aioredis.create_redis(('localhost', 6379))
ch, *_ = await sub.subscribe('news')
async for msg in ch.iter(encoding='utf-8'):
# Forward message to all connected websockets:
Expand All @@ -956,7 +956,7 @@ signal handlers as shown in the example below::


async def start_background_tasks(app):
app['redis_listener'] = app.loop.create_task(listen_to_redis(app))
app['redis_listener'] = asyncio.create_task(listen_to_redis(app))


async def cleanup_background_tasks(app):
Expand Down