[Cadence 1.0] Add ProtocolStateVersionUpgrade service event
#419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
accepting broken assets.go, will regenerate after cherry-pick is complete
broken assets.go
This was referenced May 2, 2024
turbolent
reviewed
May 3, 2024
Previously service events could only be emitted in the system chunk. With onflow/flow-go#5828, we can directly emit them in governance transactions.
2 tasks
…tate-upgrade-event
jordanschalm
added a commit
to onflow/flow-go
that referenced
this pull request
May 7, 2024
jordanschalm
changed the base branch from
stable-cadence
to
feature/efm-recovery
jordanschalm
changed the base branch from
feature/efm-recovery
to
stable-cadence
2 tasks
|
Closing in favour of #464 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a minimal version of a service event to upgrade the protocol state version (see also onflow/flow-go#5428). This is a Cadence 1.0 compatible port of #411.
There is an integration test validating the new service event is processed in onflow/flow-go#5477.
Context
The plan is to deploy this changes alongside EFM Recovery (see branch
Outstanding TODOs
TestProtocolVersionUpgradeintegration test inflow-gobefore merging.For now, I have added this service event to the
NodeVersionBeaconcontract, which has some benefits and drawbacks:ProtocolStateVersionUpgradedoes something similar to the existing Version Beacon, so it makes sense for their logic to be togetherProtocolStateVersionUpgradecleanly difficult