[KVStore] Integration test for version upgrade #5477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
jordan/5351-upgrade-service-event
to
feature/protocol-state-kvstore
March 11, 2024 21:01
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/protocol-state-kvstore #5477 +/- ##
===================================================================
- Coverage 56.02% 44.38% -11.64%
===================================================================
Files 1025 114 -911
Lines 98784 13515 -85269
===================================================================
- Hits 55339 5998 -49341
+ Misses 39303 7068 -32235
+ Partials 4142 449 -3693
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
to f59efe400a8bd77c29a6124f797b466ae4927c15
…an/5326-integration
- require consecutive versions - bootstrap with v0 rather than v1 - ignore invalid service events
- don't panic on unknown service events when determining metrics - added todo to clean up metrics
2 tasks
jordanschalm
changed the title
jordanschalm
requested review from
AlexHentschel and
durkmurder
and removed request for
zhangchiqing
| @@ -877,6 +877,7 @@ func (m *FollowerState) epochTransitionMetricsAndEventsOnBlockFinalized(block *f | |||
| // Suppose an EpochSetup service event is emitted during execution of block A. C seals A, therefore | |||
| // we apply the metrics/events when C is finalized. The first block of the EpochSetup | |||
| // phase is block C. | |||
| // TODO: this should read data from the KVStore/ProtocolStateEntry for the block rather than parsing service events | |||
There was a problem hiding this comment.
lets capture this in an issue. I am worried that if we forget that, there might be an unnecessary pager duty alert going out
There was a problem hiding this comment.
👍 It's captured in #5666.
AlexHentschel
approved these changes
Apr 26, 2024
Base automatically changed from
jordan/5120-sealing-segment
to
feature/protocol-state-kvstore
April 26, 2024 15:25
durkmurder
approved these changes
Apr 26, 2024
jordanschalm
merged commit d1faa23
into
feature/protocol-state-kvstore
55 checks passed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an integration test for the protocol state version upgrade process.
InvalidEpochTransitionAttemptedfield from KVStoreRemaining TODOs
InvalidEpochTransitionAttemptedfield from kv store (duplicated from epoch protocol state entry)