Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Service Events emitted outside the system chunk #5828

Closed
jordanschalm opened this issue May 1, 2024 · 0 comments
Closed

Allow Service Events emitted outside the system chunk #5828

jordanschalm opened this issue May 1, 2024 · 0 comments
Assignees
@jordanschalm
Labels
Execution Cadence Execution Team Protocol Team: Issues assigned to the Protocol Pillar. S-BFT
Milestone
EFM-Q2 EFM Core u...

Comments

@jordanschalm
Copy link
Member

jordanschalm commented May 1, 2024 •
edited
Loading

Problem Definition

The current definition of service events requires governance-triggered service events to be stored then later emitted by the system chunk, adding uneeded complexity to system contracts. See Revising Service Event Constraints (Notion) for details

Proposed Solution

Remove the constraint the service events must be emitted within the system chunk. See Revising Service Event Constraints (Notion) for details

Definition of Done
@jordanschalm jordanschalm added Protocol Team: Issues assigned to the Protocol Pillar. Execution Cadence Execution Team S-BFT labels May 1, 2024
@jordanschalm jordanschalm added this to the EFM-Q2 EFM Core updates milestone May 1, 2024
This was referenced May 2, 2024
Closed
Merged
@jordanschalm jordanschalm self-assigned this May 3, 2024
@jordanschalm jordanschalm mentioned this issue May 3, 2024
Merged
1 task
jordanschalm added a commit to onflow/flow-core-contracts that referenced this issue May 6, 2024
@jordanschalm
emit service event in governance transaction
b2b78d0 
Previously service events could only be emitted in the system chunk.
With onflow/flow-go#5828, we can directly emit
them in governance transactions.
@jordanschalm jordanschalm mentioned this issue May 7, 2024
Merged
2 tasks
jordanschalm added a commit to onflow/flow-core-contracts that referenced this issue Oct 28, 2024
@jordanschalm
emit service event in governance transaction
3cee1ed 
Previously service events could only be emitted in the system chunk.
With onflow/flow-go#5828, we can directly emit
them in governance transactions.
@jordanschalm jordanschalm mentioned this issue Oct 28, 2024
Merged
2 tasks
jordanschalm added a commit to onflow/flow-core-contracts that referenced this issue Oct 29, 2024
@jordanschalm
Add ProtocolStateVersionUpgrade service event (#464)
807cf69 
* add service event definition and doc

* move service event to version beacon

* add heartbeat/admin process for proto state version

accepting broken assets.go, will regenerate after cherry-pick is
complete

* add smoketest for setting protostate version

broken assets.go

* Apply suggestions from code review

* generate

broken assets.go

* update contract for cadence1

* update admin tx for cadence 1

* generate

* emit service event in governance transaction

Previously service events could only be emitted in the system chunk.
With onflow/flow-go#5828, we can directly emit
them in governance transactions.

* re-generate assets

* fix field reflection

* add context for where validation occurs and multiple emissions

* make generate
@jordanschalm jordanschalm mentioned this issue Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jordanschalm jordanschalm

Labels
Execution Cadence Execution Team Protocol Team: Issues assigned to the Protocol Pillar. S-BFT
Projects
None yet
Milestone
EFM-Q2 EFM Core updates
Development

No branches or pull requests
1 participant
@jordanschalm